[policy, no patch] Move image rotation code from core into contrib

Created on 2 October 2021, about 3 years ago

Updated 17 October 2023, about 1 year ago

Problem/Motivation

Image rotation code is, AFAICS, not used in any default setup in core, it's definitely a burden to maintain there, and has very little focus by contributors and maintainers.

This includes the GD Toolkit rotate operation class, the ImageEffect, the component Rectangle class, maybe other?

Along time a number of issues, mostly still open, were filed:

#2918570: Drupal\KernelTests\Core\Image\ToolkitGdTest fails on PHP 7.1.x-dev and 7.0.x-dev following a PHP bugfix → - 4 years old, still unsolved, and together with the issue below, the only 'Consistent failure' issue in 🌱 [meta] Known intermittent, random, and environment-specific test failures Active
#2921123: Adjust Rectangle class to calculate rotated image dimensions according to libgd 2.2.2+ → - core is still calculating rotated image dimensions in transformDimensions() as if it was running on PHP 5
#1551686: Image rotate dimensions callback can calculate new dimensions for every angle →
#2420789: Make RotateImageEffect's random rotation deterministic, so ::transformDimensions() can return the actual dimensions →
#2576639: "Regression": accept floats for degrees in rotate effect →
#2215369: Various bugs with PHP 5.5 imagerotate(), including when incorrect color indices are passed in →
📌 Move GD-specific code from Rotate::validateArguments() to Rotate::execute() Needs work
#2796369: [PP-1] Cleanup gd/Rotate::execute() arguments array overloading →

Proposed resolution

Deprecate the code for removal, and move it to contrib, where we can fix all the above more quickly. The Image Effects → module could be a good candidate for that.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

🌱 Plan

Status

Closed: won't fix

Version

11.0 🔥

Component

Image system →

Last updated 1 day ago

Maintained by
🇷🇴Romania @claudiu.cristea

Created by

🇮🇹Italy mondrake 🇮🇹

Live updates comments and jobs are added and updated live.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment almost 2 years ago →
🇺🇸United States smustgrave
Comment about 1 year ago →
🇮🇹Italy mondrake 🇮🇹
There's no traction here. Won't fix?
Status changed to Needs work about 1 year ago1:42pm 17 October 2023
Comment about 1 year ago →
needs-review-queue-bot
The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
Status changed to Closed: won't fix about 1 year ago2:25pm 17 October 2023
Comment about 1 year ago →
🇮🇹Italy mondrake 🇮🇹
Also the bots are against :), let's close this.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024