- 🇬🇧United Kingdom joachim
Tagging as novice.
There are docs in the patch at ✨ Allow callback for Url source, and single item Json plugin RTBC that should be extracted and used here -- omit the final section about the callback property, since that is new in that issue.
- First commit to issue fork.
- Merge request !94Issue #3232212: Add documentation for Url source plugin → (Closed) created by adwivedi008
- Merge request !95Issue #3232212: Add documentation for Url source plugin → (Open) created by adwivedi008
- Status changed to Needs review
7 months ago 7:21am 3 May 2024 - 🇮🇳India adwivedi008
@joachim
I have updated the documentation using https://www.drupal.org/files/issues/2020-05-29/3040427-37-migrate_plus_m... →
and https://www.drupal.org/files/issues/2020-05-17/3040427-32-migrate_plus_m... → as reference as you have mentioned in #5Closed MR of #7 as that was not correct and was opened by mistake apology for that
Please review the changes and inform if any other changes are required
- Status changed to Needs work
7 months ago 8:59am 3 May 2024 - 🇬🇧United Kingdom joachim
Hi.
It looks like you've taken the whole of the patch from the other issue. We only want the docs, and not all of the docs.
- Status changed to Needs review
7 months ago 5:22am 5 May 2024 - 🇮🇳India adwivedi008
@jochim updated the MR as per your suggestions
Apology for the bulk changes as I get confused about bringing the whole doc changes vs only document part changesMoving the issue to needs review.
- Status changed to Needs work
7 months ago 9:02am 6 May 2024