Move hasRole() method from UserInterface to AccountInterface

Just stumbled across a TODO pointing to this issue in the core.

I'm not in the position to judge about the big picture consequences following from this change, but to me it looks logical and brings consistency.

Rebased original code to the 11.x, removed TODO's from where they were referring to this issue, updated method signatures where necessary. Code style checked - no new violations added.

Will see what test results would look like.

Had to create new branch and a merge request as it's impossible (at least for me) to change existing merge request target.

New MR is https://git.drupalcode.org/project/drupal/-/merge_requests/6931

@Berdir re #17 maybe easier to move UserInterface to core and get rid of AccountInterface?

smustgrave → changed the visibility of the branch 3228209-add-accountinterface-hasrole to hidden.

Tests are still passing, @andypost, do you have specific objections to this?

From a developer perspective this is really nice for consistency.

Asked about this in #needs-review-queue-initative and @xjm mentioned can move this to RTBC if feel this is ready and just missing release manager sign off.

Haven't seen a follow up to #26 so looking at just the MR I do not see any issue with the move. Typehints appears good too.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.