- 🇭🇺Hungary Gábor Hojtsy Hungary
Wow, there is also ✨ Add options to provide drush analyze output in JSON and CSV Needs review , but this may guide the JSON format better to align with an industry solution :)
- 🇭🇺Hungary Gábor Hojtsy Hungary
Also ✨ Add UI option to export Upgrade Status results as CSV Needs review is somewhat similar.
- 🇦🇺Australia kim.pepper 🏄♂️🇦🇺Sydney, Australia
Docs link is a 404. I think it's moved to https://docs.gitlab.com/ee/ci/testing/code_quality.html
- 🇭🇺Hungary Gábor Hojtsy Hungary
Just now I merged 🐛 The analyze command should report proper exit code Fixed so now there is
--format
support on theanalyze
command where this should go instead of its own command.Also I added drush command testing there which this should extend.
Finally, I looked at the current GitLab CI docs at https://docs.gitlab.com/ee/ci/testing/code_quality.html and Code Climate docs at https://github.com/codeclimate/platform/blob/master/spec/analyzers/SPEC.... (which the GitLab CI solution is based on) and it appears like you added the
category
element as raw value of Upgrade Status category, which is not supported by either. Code Climate does not require the fingerprint but GitLab CI appears so, so that looks good. However both require acheck_name
defined that is not in the patch. So that is still to be done. I think it could either be "Upgrade Status" or we can lightly expand the analyzers in Upgrade Status to give a bit more info, so we can identify the checker at least (eg. PHPStan, Info/composer checker, CSS deprecation checker, etc). I don't know how specific are those checker names usually with other tools. - Status changed to Needs work
9 months ago 7:08pm 1 March 2024 - First commit to issue fork.
- Assigned to RoSk0
- Status changed to Active
8 months ago 1:09am 22 March 2024 - Merge request !76Support generating Code Quality JSON reports (for GitLab CI integration) → (Merged) created by RoSk0
- Issue was unassigned.
- Status changed to Needs review
8 months ago 11:04am 22 March 2024 - 🇳🇿New Zealand RoSk0 Wellington
Moved code from patch #4 into the
analyze
Drush command as requested in #11.Added format test. It would be good to also add integration test that would actually scan one of the test modules and throw that into GitLab to consume. However the check would really only be done by a human to make sure it's parse and displayed in the GitLab UI, so not sure how much value in it. Could be a follow up.
Added all required by the spec fields.
- 🇭🇺Hungary Gábor Hojtsy Hungary
Aw, such a perfect update! Thanks for being so thorough! I would love to get this and give it some publicity. How would someone go about integrating this into their drupal.org modules's CI workflow and optionally if they have their own gitlab (or github) CI setup, how would this be possible to integrate there?
-
Gábor Hojtsy →
committed 071983cc on 4.x authored by
RoSk0 →
Issue #3227079 by RoSk0, bartlangelaan, Gábor Hojtsy, kim.pepper:...
-
Gábor Hojtsy →
committed 071983cc on 4.x authored by
RoSk0 →
- Status changed to Fixed
7 months ago 12:36pm 28 April 2024 - 🇭🇺Hungary Gábor Hojtsy Hungary
Trying this out now on 📌 Test code quality analysis integration of Upgrade Status Active .
Automatically closed - issue fixed for 2 weeks with no activity.