The analyze command should report proper exit code

@andypost that still does not change how Drush interprets the result though?

AFK ATM but Drush 13 still using same codes
https://github.com/drush-ops/drush/blob/fede207f56a7fa9624d0c3b658d793a1...

Duh, Moshe says the last line that I was complaining about is not from Drush but probably ddev :D So nothing to see here. Let's introduce the exit code then and accept our fate of running from ddev resulting in confusing messaging. Can someone help convert the patch to MR to help run it against our CI?

Gábor Hojtsy → changed the visibility of the branch 3175323-the-analyze-command to hidden.

MRified it. I went ahead a bit and unified the analyze commands with a format key, so we can more easily add more formats and still get the exit code feature without needing to implement it that many times. I used most of the patch.

Gábor Hojtsy → credited moshe weitzman → .

I asked Moshe about official ways to deprecate Drush commands. While I will not follow it to keep it working for now, this was the suggestion that will be useful in the future as a potential next step to make the checkstyle command obsolete.

Empty out the code in the command, change the method description to something helpful, and add the [#Obsolete] Attribute. Here are examples https://github.com/drush-ops/drush/blob/13.x/src/Commands/LegacyCommands...

LegacyCommands.php
    /**
     * site:alias-convert has been removed. Please use Drush 11 or convert by hand.
     */
    #[CLI\Command(name: 'site:alias-convert', aliases: ['sa-convert', 'sac'])]
    #[CLI\Obsolete]

If you want it to keep working, then there is no standard way. Just log a notice or debug that the command is deprecated.

One thing to note from here is to not fire an error but a notice instead.

Landed, thanks all!

Automatically closed - issue fixed for 2 weeks with no activity.