- π§πͺBelgium tim-diels Belgium π§πͺ
This should be targeted towards the 2.x branch.
- Status changed to RTBC
about 2 months ago 3:16pm 3 May 2024 - π§πͺBelgium tim-diels Belgium π§πͺ
I've tested the code and it works as expected, so for me it is RTBC. I created a new MR against 2.x with same code and tested it.
- Status changed to Needs work
about 1 month ago 8:10pm 28 May 2024 - π©πͺGermany diqidoq Berlin | Hamburg | New York | London | Paris
Please do not set RTBC by own patches without review of others.
Again: Thanks for the report and the work in here. Very much appreciated. But some nitpics:
- $items[] = ['#markup' => Link::fromTextAndUrl($label, $url)->toString()]; + if ($domain->isActive()) { + $url->mergeOptions(['attributes' => ['class' => 'active']]); + } + $items[] = [ + '#type' => 'link', + '#url' => $url, + '#title' => $label, + ];
These changes do not only add active class in case but also change/replace the
['#markup' => Link::fromTextAndUrl($label, $url)->toString()];
without documentation in the issue comments. This should be documented and explained even if obvious for the patch provider, so that follow up issues can better be tracked down and find its root causes. - π§πͺBelgium tim-diels Belgium π§πͺ
I only added the code that was already provided. but fair enough I follow that I can not set own patches/MR as RTBC.
What do you need from us to continue in this issue? Some sort of CR so everybody knows what happend and that can be linked in this issue and in the release notes? Or were you thinking about something else?