Race condition when creating menu links and editing content deletes menu links

I've improved the MR with a bug fix raised after upgrading to Drupal 10: the menu links were created even the option 'Provide a menu link' was unchecked. It also contains tests that prove the main error of this issue does not happen again.

The patch is now tested against 10.1.x

Please review, thanks!

MR 872 should be closed and an 11.x opened.

Could screenshots of the new error be added ot the issue summary please.

omarlopesino → closed merge request !872

I think a video will help better to understand the problem as it involves many steps to reproduce the issue.

I will work on the 11.x MR, and adding a video that shows the problem.

In the meanwhile, adding a new patch for 10.x in case is needed.

Updated patch for 10.1.x, I've accidentally created it in 10.0.x

Attached a video showing the problem in a fresh 11.x Drupal with standard profile. It is linked in 'Steps to reproduce'.

Feedback from #14 has been solved:

1. Added video showing the problem in 'Steps to reproduce'
2. MR 872 is closed, and 5262 has been created

Please review the latest contributions to the issue, thanks!

Rebased to run test-only feature

1) Drupal\Tests\menu_ui\Functional\MenuUiNodeTest::testMenuNodeRaceConditions
Menu link concurrently created hasn't been deleted.
Failed asserting that null is an instance of interface "Drupal\menu_link_content\MenuLinkContentInterface".
/builds/issue/drupal-3221319/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:121
/builds/issue/drupal-3221319/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:55
/builds/issue/drupal-3221319/core/modules/menu_ui/tests/src/Functional/MenuUiNodeTest.php:513
/builds/issue/drupal-3221319/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
FAILURES!
Tests: 5, Assertions: 134, Failures: 1.

Followed the steps in the mp4 and confirmed the menu link was deleted.
Applying MR and following the same steps the menu link is not deleted.

Fixed up the issue summary.

Data loss means this is critical.

This is one of those issues that confusingly goes back and forth between patch and MR. If the MR is canonical, please hide the patch from the IS. Thanks!

Sure! The MR is canonical so I've just hidden the patch.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

MR still applies so not sure what the bot is looking at.

Left a comment on the MR.