- 🇩🇪Germany Grevil
I don't think hook_dfp_tag_load_alter(), makes sense in D10.
- Merge request !13Issue #3220030 by Grevil: Implement hook_dfp_tag_alter() → (Open) created by Grevil
- Issue was unassigned.
- Status changed to Needs review
5 months ago 2:28pm 6 February 2024 - Status changed to RTBC
5 months ago 2:36pm 6 February 2024 - Status changed to Needs work
3 months ago 5:41pm 13 March 2024 - 🇩🇪Germany Anybody Porta Westfalica
Just found an issue with this implementation: 🐛 Tag altering is not represented in caching (= wrong ads targeting shown) Needs work
While it's super important to have the flexibility this hook provides, it doesn't care for caching.
I'm not even sure if the issue described doesn't also happen in other cases already, but at least for this MR the differences in targeting for the same tag need to be taken into account!We may decide to merge that other issue in here and fix it here. But first we need to find a correct solution.
Any ideas everyone here?