- 🇮🇪Ireland markconroy
+++ b/templates/moderation-sidebar-info.html.twig @@ -19,6 +19,6 @@ + <p>{{ 'Last edited by' | t }} {{ revision_author_link }} {{ revision_time_pretty }}</p>
This might be better in a
trans
tag. The order of your variables may not be the same in all languages.Suggest:
{% trans %} Last edited by {{ revision_author_link }} {{ revision_time_pretty }} {% endtrans %}
- Status changed to Needs review
almost 2 years ago 12:16pm 23 February 2023 - 🇮🇳India mrinalini9 New Delhi
Updated patch #3 by addressing #4, please review it.
Thanks!
The last submitted patch, 5: change-label-for-authored-by-3219677-5.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- 🇮🇳India mrinalini9 New Delhi
Fixing coding standard issues in #5, please review it.
- Open on Drupal.org →Core: 9.5.5 + Environment: PHP 7.4 & MySQL 5.7last update
about 1 year ago Waiting for branch to pass - 🇷🇺Russia gifthorse
- revision_author_link is a render array and should be passed through render before going to trans.
- #3 has nothing to do with changing the label, and if it's a problem then it should be addressed in its own issue IMO.
- So here is the patch fixing only the twig file.
- First commit to issue fork.
- Open on Drupal.org →Core: 9.5.5 + Environment: PHP 7.4 & MySQL 5.7last update
7 months ago Waiting for branch to pass - Open on Drupal.org →Core: 9.5.5 + Environment: PHP 7.4 & MySQL 5.7last update
7 months ago Waiting for branch to pass - Status changed to Postponed
4 months ago 4:56pm 27 August 2024 - 🇺🇸United States japerry KVUO
Since this changes the UI, it will likely break downstream dependencies (especially tests) and thus is postponed to a new major version.