Contrib.social

Taxonomy views filter Display error message setting is redundant

Open on Drupal.org →
Created on 18 May 2021, over 3 years ago
Updated 27 January 2023, almost 2 years ago

Problem/Motivation

The 'Display error message' setting in the taxonomy_index_tid views filter ('Has taxonomy term ID') is not used. The functionality that used it, was removed in #2428881: Remove TermAutocompleteController::autocompletePerVid() → , without removing the setting. It is now unnecessary clutter in the user interface.

Steps to reproduce

Add the 'Has taxonomy term ID' filter to a view, expose the filter. The setting appears.

Proposed resolution

Remove the setting.

Remaining tasks

Implementation & review.

User interface changes

Removes redundant form element.

API changes

Data model changes

Release notes snippet

📌 Task
Status

Needs work

Version

10.1 ✨

Component
Taxonomy  →

Last updated 9 minutes ago

  • Maintained by
  • 🇺🇸United States @xjm
  • 🇬🇧United Kingdom @catch
Created by

🇬🇧United Kingdom james.williams

Live updates comments and jobs are added and updated live.
  • Needs subsystem maintainer review

    It is used to alert the maintainer(s) of a particular core subsystem that an issue significantly impacts their subsystem, and their signoff is needed (see the governance policy draft for more information). Also, if you use this tag, make sure the issue component is set to the correct subsystem. If an issue significantly impacts more than one subsystem, use needs framework manager review instead.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment almost 2 years ago →
    🇺🇸United States smustgrave

    This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.

    Tested again in D10 on the main content view
    Adding a filter for tags exposed
    Search for a term that doesn't exist I get the error.

    Apply the patch
    Still get the same results.

    Tagging for subsystem maintainer review for their thoughts.

    patch will have to be updated for D10 though as it doesn't cleanly apply.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024