Starterkit theme: Add JavaScript file with example Drupal behaviors (with documentation)

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Moving to NW for the open threads.

+1 for pointing to docs for once()

Can the changes to core/lib/Drupal/Core/Command/GenerateTheme.php be reverted?

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Thank you mister robot.

Added the missing new line at the end of the file.

Needs review.

Thanks! Believe this is ready.

Rebased
I see issues with eslint on yarn lint:core-js

/var/www/html/drupal/core/themes/starterkit_theme/js/reading-time.js
   6:2  warning  Unexpected unnamed function   func-names
  30:6  warning  Use @return instead           valid-jsdoc
  65:9  warning  Unexpected console statement  no-console

Second warning is fixed, what to do with the rest warnings?

Posted comment in the MR

@matthieuscarset I think that sounds like a great idea and a good example.

Oups! sorry, this is actually already what I did! 🤦‍♂️ I forgot to re-read myself.

@lauriii's question is still relevant.

Do we want to keep console.log() or should we use something more visual, such as alert() or Drupal.message ?

Think console.log and maybe Drupal.message would be good examples.

Console.log for debugging
Drupal.message for themers

Reran tests and they still fail, so think failure is related to the change.

Just rebase on top of 11.x and rerun the whole pipeline.

The failures are not related to changes on this issue.

Not sure how to handle this situation... but unless I'm wrong, the current issue is done and can be RTBC .

Rerunning again but I don’t see that HEAD is broken. So if this can’t pass all the tests can’t mark it RTBC

Ran here again and locally and it fails. Somehow this change is being picked up.

I need help to understand why an unrelated test is constantly failing in this MR

I merged latest code from 11.x and run the pipeline again but it is still failing at Drupal\FunctionalJavascriptTests\Core\JsMessageTest.

If I run the test locally, it passes without errors (see screenshot below).

Any help much appreciated! TY

Posted a comment on the MR, hopefully that helps some.

Gauravvvv → made their first commit to this issue’s fork.