Contrib.social

Compatibility with s3fs module

Open on Drupal.org →
Created on 16 April 2021, over 3 years ago
Updated 14 February 2024, 9 months ago

Problem/Motivation

With the s3fs module installed, the upload of the archive is successful but the parsing of the .xml and .webmanifest configurations files returns an error :

Warning: file_get_contents(): Filename cannot be empty in Drupal\responsive_favicons\Form\ResponsiveFaviconsAdmin->submitForm() (line 178 of modules/contrib/responsive_favicons/src/Form/ResponsiveFaviconsAdmin.php).
Warning: file_get_contents(): Filename cannot be empty in Drupal\responsive_favicons\Form\ResponsiveFaviconsAdmin->submitForm() (line 170 of modules/contrib/responsive_favicons/src/Form/ResponsiveFaviconsAdmin.php).

Steps to reproduce

Send an archive with the s3fs module activated and params in a public s3 bucket.

Proposed resolution

I propose to delete $this->fileSystem->realpath when getting the contents of the files. This fix still allows retrieving files with the s3fs module installed or with the base Drupal file system.

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task
Status

RTBC

Version

1.0

Component

Code

Created by

🇫🇷France jenue1933 Bordeaux

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024