Compatibility with s3fs module

Warning: file_get_contents(): Filename cannot be empty in Drupal\responsive_favicons\Form\ResponsiveFaviconsAdmin->submitForm() (line 178 of modules/contrib/responsive_favicons/src/Form/ResponsiveFaviconsAdmin.php). Warning: file_get_contents(): Filename cannot be empty in Drupal\responsive_favicons\Form\ResponsiveFaviconsAdmin->submitForm() (line 170 of modules/contrib/responsive_favicons/src/Form/ResponsiveFaviconsAdmin.php).

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment 9 months ago →
🇪🇸Spain pcambra Spain, 🇪🇺
This needs update for Drupal 10:

Error: Call to undefined function file_create_url() in _responsive_favicons_normalise_path() (line 192 of modules/contrib/responsive_favicons/responsive_favicons.module).
Comment 9 months ago →
🇪🇸Spain pcambra Spain, 🇪🇺
Status changed to Needs review 9 months ago10:58am 13 October 2023
Comment 9 months ago →
🇪🇸Spain pcambra Spain, 🇪🇺
Not sure why there isn't a 2.0.x branch, adding the patch for the 8.x-1.x replacing file_create_url by \Drupal::service('file_url_generator')->generateAbsoluteString($uri) as per https://www.drupal.org/node/2940031 →
Comment 5 months ago →
🇮🇹Italy Noemi Milan
I tested patch #15 📌 Compatibility with s3fs module Needs review and it works fine on 2.0.x version.
Status changed to RTBC 5 months ago9:48am 14 February 2024
Comment 5 months ago →
🇪🇸Spain pcambra Spain, 🇪🇺

Compatibility with s3fs module

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comments & Activities