- 🇫🇷France andypost
Yes, not clear which entity does not implement this interface and why it's serialized
- Status changed to Needs review
almost 2 years ago 3:26pm 4 May 2023 - last update
almost 2 years ago 13 pass - 🇫🇷France andypost
If there's reason to process broader types there's
FieldableEntityInterface
which can be used as the argument type for\Drupal\default_content\Normalizer\ContentEntityNormalizer::addDependency()
The method using only 2 methods of
EntityInterface
so here's a patch - last update
over 1 year ago 13 pass - 🇪🇸Spain empesan
Sometimes exporting of entities resulted in the following error:
TypeError: Drupal\default_content\Normalizer\ContentEntityNormalizer::addDependency(): Argument #1 ($entity) must be of type Drupal\Core\Entity\EntityInterface, null given, called in /app/modules/contrib/default_content/src/Normalizer/ContentEntityNormalizer.php on line 453 in /app/modules/contrib/default_content/src/Normalizer/ContentEntityNormalizer.php on line 482 #0 /app/modules/contrib/default_content/src/Normalizer/ContentEntityNormalizer.php(453): Drupal\default_content\Normalizer\ContentEntityNormalizer->addDependency(NULL)
so I rerolled the latest patch and added a double check to assert that the argument being sent to addDependency() function is always an EntityInterface
- Status changed to Needs work
7 months ago 10:29pm 23 August 2024 - 🇨🇭Switzerland berdir Switzerland
Merge request wasn't updated with recent patches, and I disagree with the API change to EntityInterface. default_content is about content entities. There's no need to expand that.
- First commit to issue fork.
- Status changed to Needs review
7 months ago 11:54pm 23 August 2024 - Status changed to Needs work
7 months ago 8:26am 24 August 2024