- π¨π¦Canada mparker17 UTC-4
I am happy to report that I was able to use this patch to successfully migrate my External Links module configuration from my
drupal-7.99
site runningextlink-7.x-1.21
to adrupal-10.2.1
site runningextlink-8.x-1.7
.Unfortunately, I cannot RTBC this issue because I wrote the patch β . But, hopefully, my success will help other people migrating D7 to D10.
Unfortunately, however, now that my D7 to D10 site migration is complete, my ability to contribute further to this issue is severely limited, because the D7 site that I had been using to test has been retired. However, I'll keep an eye on this issue and try to answer questions to the best of my ability.
- π©πͺGermany Anybody Porta Westfalica
@mparker17 could you please turn this into a MR?
@Wim Leers, 2Y later still plans for review? ;D (joking, sorry)
- Merge request !12[#3199408] Migrate configuration from 6.x-1.x, 7.x-1.x. β (Closed) created by mparker17
- π¨π¦Canada mparker17 UTC-4
@Anybody, sure! Here's a link to !12, where I applied the patch from #6 β¨ Migrate configuration from 6.x-1.x, 7.x-1.x Needs review .
- First commit to issue fork.
- Status changed to Needs work
3 days ago 3:14am 26 June 2024 - πΊπΈUnited States smustgrave
Should note the warnings for stylelint are known and Iβll fix in another ticket
- π¨π¦Canada mparker17 UTC-4
The remaining lints are happening in files that weren't changed in this MR (i.e.:
eslint
failing because ofextlink.js
;phpstan (next major)
failing because ofsrc/Form/ExtlinkAdminSettingsForm.php
;stylelint
failing because ofextlink.css
.I also see
Drupal\Tests\extlink\FunctionalJavascript\ExtlinkAdminTest::testExtlinkDisabledOnAdminRoutes
is failing in several tests, and nothing related to that was changed in the merge request.That being said, I see
Drupal\Tests\extlink\Kernel\ValidateD6SettingsMigrationTest::testMigration
andDrupal\Tests\extlink\Kernel\ValidateD7SettingsMigrationTest::testMigration
are failing, and those were changed here, so I'll work on those. - πΊπΈUnited States smustgrave
Drupal\Tests\extlink\Kernel\ValidateD6SettingsMigrationTest::testMigration and Drupal\Tests\extlink\Kernel\ValidateD7SettingsMigrationTest::testMigration are failing,
Message I'm getting is that extlink is not enabled on source site.
- Status changed to Needs review
1 day ago 11:14pm 26 June 2024 - πΊπΈUnited States smustgrave
Have 0 idea if that's correct, I copied the fixtures from another module but they seem to be passing now.
- π¨π¦Canada mparker17 UTC-4
@smustgrave, thank you! In this case, as long as the fixtures set up the tables needed for the test, then I'd say it's fine.
(Normally I would RTBC at this point, but since I wrote some of the patch, and I don't have a migration to test anymore, I probably shouldn't)
-
smustgrave β
committed 7ca93412 on 2.0.x
Issue #3199408 by mparker17, smustgrave, Wim Leers, Anybody: Migrate...
-
smustgrave β
committed 7ca93412 on 2.0.x
- Status changed to Fixed
1 day ago 1:39pm 27 June 2024 - πΊπΈUnited States smustgrave
It's non disruptive so I don't mind merging. Thanks for taking a look!