Contrib.social

ConfigDistroIgnoreController missing parent

Open on Drupal.org →
Created on 18 February 2021, almost 4 years ago
Updated 2 August 2023, over 1 year ago

Problem/Motivation

We recently checked a codebase containing Config Distro for PHP 7.4 compatibility using the PHPCompatibility Coding Standard for PHP CodeSniffer.

The following problem was detected within Config Distro:

FILE: /app/web/modules/contrib/config_distro/modules/config_distro_ignore/src/Controller/ConfigDistroIgnoreController.php
-------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------
 26 | ERROR | Using "parent" inside a class without parent is deprecated since PHP 7.4
-------------------------------------------------------------------------------------------------------------------------

Proposed resolution

It looks to me like this class is meant to extend Drupal\config\Controller\ConfigController like ConfigDistroController does.

Remaining tasks

Create patch that adds parent class to ConfigDistroIgnoreController.

🐛 Bug report
Status

Fixed

Version

2.0

Component

Code

Created by

🇺🇸United States joegraduate Arizona, USA

Live updates comments and jobs are added and updated live.
  • PHP 7.4

    The issue particularly affects sites running on PHP version 7.4.0 or later.

  • PHP 8.1

    The issue particularly affects sites running on PHP version 8.1.0 or later.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024