Seville, Spain
Account created on 3 March 2015, almost 10 years ago
#

Recent comments

πŸ‡ͺπŸ‡ΈSpain lluvigne Seville, Spain

Here is a new patch version with changes to not break pin positions when saving existing widgets changes.

πŸ‡ͺπŸ‡ΈSpain lluvigne Seville, Spain

Hello!

There are a couple of things that needs to be addressed before going ahead with this issue:

- We are mixing two issues here: code from 3352443 πŸ› Incompatibility with hook_event_dispatcher module Active is present in this patch. This should not be the case. We will need the issue to be fixed, but we can not add the same changes here. For that I'm creating a new patch and interdiff attached to this comment.

- The edit form should have a proper naming inside interface.
- Ajax functionality can not work for the entire wrapper of forms. Should work only for the selected form, and wrapper id can not be test, we should change it.
- The issue description is not complete. Please, we need to add more info to it.

πŸ‡ͺπŸ‡ΈSpain lluvigne Seville, Spain

Tested with Drupal 10 and release 2.1.3 and works well.

Since update hook on 3351776 πŸ“Œ String data, right truncated: 1406 Data too long for column 'args' at row 1: INSERT INTO "draggableviews_structure" Fixed was included in the latest stable release, we need to add a new hook update to repeat the same process as before, to update installations that could happened in this time interval. I added a new hook to MR that execute the update number 8105 (I did it that way to keep trace of the original update and issue where that update was created).

For me, change in schema works great. Just this update needs to be reviewed.

πŸ‡ͺπŸ‡ΈSpain lluvigne Seville, Spain

lluvigne β†’ made their first commit to this issue’s fork.

πŸ‡ͺπŸ‡ΈSpain lluvigne Seville, Spain

#49 patch works nice! Would be great to have this on a stable release.

πŸ‡ͺπŸ‡ΈSpain lluvigne Seville, Spain

Hello!

I'm just updating the changes to fit D10 requirements since file_url_transform_relative() and file_create_url() are deprecated and the patch is not working anymore.

I will not change the issue status since the changes requested on #4 are still pending.

πŸ‡ͺπŸ‡ΈSpain lluvigne Seville, Spain

Hello!

I've tested the MR provided in #4 and is working fine.
This issue it's not only affecting hook_event_dispatcher module, also other modules that decorates the core module handler, like config_track β†’ . So widget form should definitely use ModuleHandlerInterface on arguments instead of the core module handler class.

I'm moving this to RTBC to push this issue forward.

πŸ‡ͺπŸ‡ΈSpain lluvigne Seville, Spain

Hi! I'm checking code compatibility with PHP 8 for a site containing config distro and found the same error.

As @bircher sais in #4 seems to be something left over as the class is not being used anywhere. Removing the class doesn't break anything. Moving the issue to RTBC.

Production build 0.71.5 2024