Make error message boxes closable

Created on 2 February 2021, almost 4 years ago
Updated 10 August 2023, over 1 year ago

Problem/Motivation

It would be a nice add if error message boxes had a close button. I use Gin so hopefully this would be inherited by Gin and sub-themes of Gin

✨ Feature request
Status

Needs work

Component

User interface

Created by

πŸ‡¦πŸ‡ΊAustralia the_glitch

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Issue was unassigned.
  • Status changed to Needs review almost 2 years ago
  • πŸ‡»πŸ‡³Vietnam tra.duong

    @atul ghate

    I have applied your patch, it work fine on:
    + Display close button.
    + Close message when click.
    But, I see a close button already exists on the claro theme. I think the styling should be identical.
    Otherwise, a light box shadow seems not Claro style.
    Here is a close button on views popup:

    My two cents

  • Status changed to Needs work almost 2 years ago
  • πŸ‡»πŸ‡³Vietnam tra.duong

    I change status to needs work

  • πŸ‡ΊπŸ‡ΈUnited States naidim

    @atul_ghate thanks for the work you did, I took @tra.duong's suggestion and implemented the dialog button's html and styles for the message. Sharing in case anyone else wants the patch, I doubt it'll make it into core but I like being able to close the messages.

Production build 0.71.5 2024