Contrib.social

Modules depending on jQuery UI have broken styling since Drupal 9.2

Open on Drupal.org →
Created on 1 February 2021, over 3 years ago
Updated 3 May 2024, 6 months ago

In Drupal 9.2.x, multiple jQuery UI libraries were deprecated. They were deprecated in #3113400: Deprecate more jQuery UI library definitions → (change record: #3156376 → ).

Previously, if a module required for example core/jquery.ui.dialog, Seven and Claro removed files that were breaking the layout. With above change, this override was removed.

This means that every module that is still depending on these deprecated libraries is possibly broken since Drupal 9.2. Some libraries that were not loaded before, are now loaded again.

The long-term fix is for these modules to not depend on the deprecated libraries. However, these libraries should still be supported until Drupal 10. That means that while the libraries should be marked deprecated, overrides and extensions on them should not be removed until Drupal 10.

Example of broken module: admin_toolbar_search
This was also the original bug report of this issue. When this module is enabled, the views modals have flickering buttons when hovering over them.
Video showing the issue: https://www.drupal.org/files/issues/2021-02-01/20210201_125018647.mp4 →

Example of broken module: webform
This was originally reported in issue #3225151: Webform button accessibility while Claro theme is enabled → . When the webform and webform_ui modules are enabled, the + Add element modal has weird looking buttons, creating an accessibility problem.

Proposed resolution
Revert the part of commit 1c201591 that removes the library overrides and extensions of deprecated libraries. They should not be removed until Drupal 10, when the deprecated libraries are removed.

🐛 Bug report
Status

Closed: outdated

Version

11.0 🔥

Component
Theme  →

Last updated about 10 hours ago

Created by

🇮🇳India djsagar

Live updates comments and jobs are added and updated live.
  • Accessibility

    It affects the ability of people with disabilities or special needs (such as blindness or color-blindness) to use Drupal.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment over 1 year ago →
    needs-review-queue-bot

    The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

    Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

    Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

  • Comment over 1 year ago →
    🇨🇦Canada mgifford Ottawa, Ontario

    I would like a clear explanation about what the accessibility bug here is. Is it a contrast problem without the jQuery UI styles?

  • Status changed to Closed: outdated 6 months ago
  • Comment 6 months ago →
    🇺🇸United States bnjmnm Ann Arbor, MI

    This issue is specific to depending on libraries that were deprecated in Drupal 9, and fully removed in Drupal 10. Drupal 9 is EOL so this will not be addressed. It is unfortunate there wasn't a solution provided during Drupal 9's lifespan, but hopefully the modules impacted by this were able to mitigate the issue without too much hassle.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024