Smart Date Recurring doesn't work in non translatable field

I've unfortunately (depending on the perspective) been able to replicate the issue again, even with the original and latest patches from 🐛 New non translatable field on translatable content throws error Needs work .

I've updated the Issue summary accordingly for how to replicate it.

Example code references with similar fixes in place:

• entity_reference_revisions
• paragraphs

I'll upload a patch for what worked for me to the issue for reference purposes, but I believe it requires more testing and definitely input from you about how best to go about it (I'd create tests for it, but I'm a bit time-constrained atm)

Based on the entity reference revisions example linked, it seems as though Smart Needs to create its own FieldItemList implementation, to override the hasAffectingChanges method in particular.

@codebymikey thanks for the additional clarification and i'm very interested to see the patch that worked for you.

Also marking ✨ Provide a simple method to expand recurring events Active as related because the changes proposed there might make it easier to implement the necessary hasAffectingChanges (or whatever the fix turns out to be).

I'm currently on 3.6.1, so I've attached a patch for that here for reference purposes since I don't want to upgrade yet.

But I'll push the equivalent code changes for the 3.7.x-dev branch for us to work from. I don't think it's the cleanest solution, but it works for my use case.

I initially wanted to go the ::hasAffectingChanges() route, since I noticed that we were casting the value, end_value and duration properties to integers when they were actually strings before they were updated, and thought that was the reason the SmartDateFieldItemList::equals() call failed on my first pass.
But on further investigation, I noticed the values were actually different rather that than just being different types, and it was somewhat erroneous since SmartDateFieldItemList::equals() actually does a loose comparison.

I think the Paragraphs approach made the most sense of detecting whether the widget is allowed to automatically make certain changes to the data or not.

Created and updated the issue fork, feedback's more than welcome!

Updated the patch to support views_bulk_edit integration, there was an issue with the assumption that the form object will always be a \Drupal\Core\Entity\EntityFormInterface which might not always be the case.

The changes from the most recent patch and merge request aren't working for me. When the EntityUntranslatableFieldsConstraintValidator checks if there are untranslatable changes, it eventually gets down to calling Drupal\Core\Field\FieldItemList::equals to check for changes. At the end of this function, it's returning $value_1 == $value_2. In my case this evaluates to false (causing the validator to throw an error) because the elements in $value_2 have an rrule_index value that $value_1 doesn't have.

$value_1[0] == [
  duration => "60",
  end_value => 1709226900,
  rrule => "136",
  timezone => "",
  value => 1709223300,
];

$value_2[0] == [
  duration => "60",
  end_value => "1709226900",
  rrule => "136",
  rrule_index => "1",
  timezone => "",
  value => "1709223300"
];

$value_1 and $value_2 both have the same number of elements and, as far as I can tell, the non-rrule_index values are all the same. So it seems like the rrule_index value is causing the check to fail.

I'm on Drupal 10.3.1 and Smart Date 4.1.5 (I rerolled the merge patch locally to get it to apply cleanly, but I didn't change any of the actual code in the MR).

I also tried the patch from #10 and got the same result (had to downgrade my Smart Date to 4.0.0 to get the patch to apply).

Thoughts? Suggestions?

Thanks!

Attached a static copy of the latest version of the merge request for 4.1.x.

Relating to 🐛 Recurring date validation is wrongly triggered even if the relevant date field is not actionable on the page (e.g. with translations) Active , ran into a bug with the current implementation where it doesn't properly process the RRules for the recurring dates when they're translated.

Steps to reproduce

1. Create a recurring date with a start and end date of 04/11/2024 01:00 PM - 04/11/2024 02:00 PM.
2. Specify that it repeats weekly on Monday, and has an ends on date of 11/11/2024.
3. Attempt to save the content, it saves just fine.
4. Translate the piece of content, and attempting to save will trigger the warning. This is because the smart date RRule was no longer being processed, but it was still attempting to validate it against the end date of 11/01/2024 12:00 AM which is smaller than the end date instance value of 11/01/2024 02:00 PM.

Proposed resolution

1. We can return early and flag the element as inaccessible with $element['#access'] = FALSE;
2. Load the smart date rules and attempt validations on it even if the field is not actually used (seems like a waste of resources).
3. Update \Drupal\smart_date_recur\Entity\SmartDateRule::validateRecurring() so it does a check if the element is not accessible to the user - if it is not accessible to the user, then it skips any subsequent validations:

if (!Element::isVisibleElement($element)) {
  // Don't attempt to validate recurring if the widget element is not
  // visible on the form - which might be the case for translations.
  // @see \Drupal\content_translation\ContentTranslationHandler::entityFormSharedElements()
  return;
}

Updating this to target the 4.2.x branch.

I just tried to reproduce this using the patch posted in #28 🐛 New non translatable field on translatable content throws error Needs work of 🐛 New non translatable field on translatable content throws error Needs work and an unpatched copy of Smart Date 4.2.x and was unable to reproduce the validation error. Could someone else test this?

Applied !MR 60 as a patch against Smart Date 4.2.0 but it did not resolve my issue - still received a validation error message about untranslatable fields.

Confirming that applying #128 🐛 New non translatable field on translatable content throws error Needs work against core 10.3.7 and an unpatched copy of Smart Date 4.2.0 resulted in no validation error on my smart_date field.

Applied !MR 60 as a patch against Smart Date 4.2.0 but it did not resolve my issue - still received a validation error message about untranslatable fields.

Applied #128 🐛 New non translatable field on translatable content throws error Needs work against core 10.3.7 and an unpatched copy of Smart Date 4.2.0 and did not receive a validation error.

I've updated the issue summary a bit more to replicate it on a clean install with the 🐛 New non translatable field on translatable content throws error Needs work patch.

As well as attached a copy of a 10.3.2 sqlite database → to demonstate the behaviour. The relevant settings.php setting is as follows after decompressing it:

$databases['default']['default'] = array (
  'database' => '/var/www/html/web/core/default/files/.smart_date-3194515._ht.sqlite',
  'prefix' => '',
  'driver' => 'sqlite',
  'namespace' => 'Drupal\\sqlite\\Driver\\Database\\sqlite',
  'autoload' => 'core/modules/sqlite/src/Driver/Database/sqlite/',
);

And can be triggered by trying to save the translation on /ja/node/1/edit.

The patch in 🐛 New non translatable field on translatable content throws error Needs work helps but doesn't solve this issue because the "original" field value is still being modified when the RRule is initially read in the translation and causes the \Drupal\Core\Entity\Plugin\Validation\Constraint\EntityUntranslatableFieldsConstraintValidator::hasUntranslatableFieldsChanges() call to return TRUE.