Account created on 20 May 2024, 7 months ago
#

Recent comments

The changes from the most recent patch and merge request aren't working for me. When the EntityUntranslatableFieldsConstraintValidator checks if there are untranslatable changes, it eventually gets down to calling Drupal\Core\Field\FieldItemList::equals to check for changes. At the end of this function, it's returning $value_1 == $value_2. In my case this evaluates to false (causing the validator to throw an error) because the elements in $value_2 have an rrule_index value that $value_1 doesn't have.

$value_1[0] == [
  duration => "60",
  end_value => 1709226900,
  rrule => "136",
  timezone => "",
  value => 1709223300,
];

$value_2[0] == [
  duration => "60",
  end_value => "1709226900",
  rrule => "136",
  rrule_index => "1",
  timezone => "",
  value => "1709223300"
];

$value_1 and $value_2 both have the same number of elements and, as far as I can tell, the non-rrule_index values are all the same. So it seems like the rrule_index value is causing the check to fail.

I'm on Drupal 10.3.1 and Smart Date 4.1.5 (I rerolled the merge patch locally to get it to apply cleanly, but I didn't change any of the actual code in the MR).

I also tried the patch from #10 and got the same result (had to downgrade my Smart Date to 4.0.0 to get the patch to apply).

Thoughts? Suggestions?

Thanks!

Production build 0.71.5 2024