- πΊπΈUnited States maddentim
I can also confirm the patch resolves the issue and applies cleanly to the 4.0.0-alpha3 release.
- last update
11 months ago 130 pass - Status changed to Needs review
10 months ago 7:05pm 1 March 2024 - π«π·France dqd London | N.Y.C | Paris | Hamburg | Berlin
Thanks for the reports and all working on this here! +1
It may solve the issue of the thrown error, but I am not sure if we should leave out ELSE completely here. Now we have IF and ELSE IF and nothing if both are not TRUE. Can somebody confirm that it is harmless and that we do not need a silent exception error or anything else to notify? Or ion other words: do we need #name? If not, why we asking for it then?
Otherwise if somebody can clarify this for me I do not see reasons not to commit. I would commit/merge it asap after another review of my question.
- last update
9 months ago Patch Failed to Apply - πΊπΈUnited States amstercad
In preparation for Drupal 11, please note the test failure of the current patch:
PHP 8.3 & MySQL 8, D10.2 Patch Failed to Apply
- First commit to issue fork.
- last update
6 months ago 130 pass - Status changed to RTBC
6 months ago 2:37pm 25 June 2024 - π¬π§United Kingdom scott_euser
I took a look at the logic and the subsequent code really does need the #name - if its missing every bit of the subsequent code falls apart as its essentially the key bit to determine the dependee. So it seems safe to me to merge it @dqd
Moved the patch to an MR for ease of merging, but no change so marking as RTBC
-
dqd β
committed 25ef661e on 4.x authored by
scott_euser β
Issue #3193825 by scott_euser, prudloff: Notice: Undefined index: #name
-
dqd β
committed 25ef661e on 4.x authored by
scott_euser β
- Status changed to Fixed
4 months ago 11:25am 25 August 2024 - π«π·France dqd London | N.Y.C | Paris | Hamburg | Berlin
Oh no, sorry, I missed that one in my notifications. +1 Thanks @scott_euser for clarifying and preparing for merge. Awesome.
@amstercad: this should be solved in one of the support Druapl 11 issues. At this moment https://www.drupal.org/project/conditional_fields/releases/4.x-dev β does not support Drupal 11 yet and so the merge should be made before compatibility issues turn this merge out of sync. I also consider to discuss with other maintainers if we probably move Drupal 11 compatibility temporary to another branch before back porting to not break merging the queue of potentially open and almost fixed issues.
Automatically closed - issue fixed for 2 weeks with no activity.