- 🇺🇸United States maddentim
I can also confirm the patch resolves the issue and applies cleanly to the 4.0.0-alpha3 release.
- last update
5 months ago 130 pass - Status changed to Needs review
4 months ago 7:05pm 1 March 2024 - 🇩🇪Germany diqidoq Berlin | Hamburg | New York | London | Paris
Thanks for the reports and all working on this here! +1
It may solve the issue of the thrown error, but I am not sure if we should leave out ELSE completely here. Now we have IF and ELSE IF and nothing if both are not TRUE. Can somebody confirm that it is harmless and that we do not need a silent exception error or anything else to notify? Or ion other words: do we need #name? If not, why we asking for it then?
Otherwise if somebody can clarify this for me I do not see reasons not to commit. I would commit/merge it asap after another review of my question.
- last update
3 months ago Patch Failed to Apply - 🇺🇸United States Amstercad
In preparation for Drupal 11, please note the test failure of the current patch:
PHP 8.3 & MySQL 8, D10.2 Patch Failed to Apply
- First commit to issue fork.
- last update
2 days ago 130 pass - Status changed to RTBC
2 days ago 2:37pm 25 June 2024 - 🇬🇧United Kingdom scott_euser
I took a look at the logic and the subsequent code really does need the #name - if its missing every bit of the subsequent code falls apart as its essentially the key bit to determine the dependee. So it seems safe to me to merge it @dqd
Moved the patch to an MR for ease of merging, but no change so marking as RTBC