twig_render_template micro optimization

The last submitted patch, 10: 3192830-10.patch, failed testing. View results →

reroll in MR

nice clean-up!

Not convinced this is really going to make any measurable difference in the real world, but it makes the code a bit easier to read.

Backported to 10.3.x as a cleanup with no functional changes.

Committed and pushed 0ba6b793c6 to 11.x and 1eac567fbb to 11.0.x and d7549f3c3a to 10.4.x and ffdafb02cd to 10.3.x. Thanks!

longwave → closed merge request !8275

Nice!

Yeah, probably not measurable from a wall clock perspective with current PHP performance hence the title. However, it removes one assignment, one function call to implode, and the admittedly trivial string concats implode is doing from every twig_render. This means on a stock Drupal install it saves 54 function calls and assignments on an uncached request to the frontpage so its at least measurable from that metric. Since most sites are probably more complex then that and as you said its actually a bit cleaner it seemed worth while.

Automatically closed - issue fixed for 2 weeks with no activity.