Only close Olivero sub-menus when resize results in a different menu format

Created on 9 January 2021, almost 4 years ago
Updated 20 January 2023, almost 2 years ago

Problem/Motivation

Follow-up to #3180086: It should not be possible to have two dropdown menus appear at the same time within Olivero β†’

That issue added logic which closes the sub-menus whenever avresize event happened. The motivation was to prevent 2 sub-menus being open if you switch

But this is too greedy. Not all viewport resizing results in a change between wide and narrow menu versions. It's reasonable to have a wide menu, then make your viewport even bigger.

Steps to reproduce

Example:I have a HD monitor (1920 x 1080), and my browser window is currently 1300 x 700. I see the wide version of the menu. Now I open a sub-menu, and it has lots of items. I'd like more room to read those, so I use the maximise-window feature of my OS. The browser viewport grows from 1300px to 1920px wide. Does the menu remain open?

Proposed resolution

Don't close menus on all resize events. Instead, close them when you decide to switch between narrow and wide menus.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

πŸ› Bug report
Status

Needs work

Version

10.1 ✨

Component
OliveroΒ  β†’

Last updated 2 days ago

Created by

πŸ‡¬πŸ‡§United Kingdom andrewmacpherson

Live updates comments and jobs are added and updated live.
  • Usability

    Makes Drupal easier to use. Preferred over UX, D7UX, etc.

  • Accessibility

    It affects the ability of people with disabilities or special needs (such as blindness or color-blindness) to use Drupal.

  • Needs manual testing

    The change/bugfix cannot be fully demonstrated by automated testing, and thus requires manual testing in a variety of environments.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

No activities found.

Production build 0.71.5 2024