Document why CORE_COMPATIBILITY is still 8.x in higher branches

I just found this issue when searching for core issues about CORE_COMPATIBILITY since I recently saw it while working on 📌 Add \Drupal::getMajorVersion() Needs work and thought "why haven't we deprecated that const yet?" 😂

I rebased the MR branch to 10.1.x, but I can't update the MR metadata to match. I probably should have just opened a new MR for the 10.1.x branch. The workflow for dealing with MRs is a PITA since only core committers and the original MR author can change the target branch. 😢

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

@dww, I changed the branch on the MR. I agree there are challenges with the MR workflow but I agree with xjm that the suggestion feature is very nice for coding standards issues.

Fabulous, thanks for updating the MR. Yeah, there are good things about the MR workflow. But it's still clunky in a lot of ways. ;) We're all doing the best we can. No shade intended.

Removing credit from myself as I just clicked the rebase button.

But seems there is a CI build issue.

Whoops, thanks for pointing that out. Trivial spelling error: s/extesions/extensions/

This is now passing core/scripts/dev/commit-code-check.sh locally.

Any thoughts on the wording of the comment, or is this now ready to go?

Thanks,
-Derek

I was going to upload a patch for 9.5.x (I really think we should backport this comment to that branch), but I just did a simulation and once this is committed to 10.1.x, git cherry-pick works cleanly to both 10.0.x and 9.5.x branches. So we only need the single MR and don't need any patches here.

Think the change makes sense. Actually never thought about 9.x-1.0 but glad to know it wouldn’t work! Haha

Committed 639b129 and pushed to 10.1.x. Cherry-picked to 10.0.x and 9.5.x. Thanks!

lauriii → closed merge request !164

Excellent, thanks!

Automatically closed - issue fixed for 2 weeks with no activity.