[meta] API function names in module/theme install/uninstall space should match UI

Created on 13 November 2020, about 4 years ago

Updated 22 August 2024, 4 months ago

Problem/Motivation

On meta issue
#2888657: [meta] Less confusing and more consistent wording needed in module/theme add/install/update →
we are updating the UI text for the actions of uploading files for a module/theme, and installing/uninstalling modules/themes.

That work is being done on these three child issues:
#2577407: Action of uploading module/theme files should consistently be called "Add", not "Install" →
📌 [Meta] Use Install/Uninstall consistently for turning modules/themes on/off (not Enable) Active
🐛 Do not use verb "Install" for things other than turning on modules/themes Fixed
Plus this one that is updating URLs:
#2888654: URLs for module/theme actions are inconsistent with UI text →

Once that is finished, we should update the API functions/classes for these actions so they are consistent with the UI terminology. This issue is postponed until all those others are done.

Proposed resolution

Note that this will need a BC layer and/or deprecations.

core/modules/ckeditor5/tests/src/Kernel/CKEditor5PluginManagerTest.php: protected function enableModules(array $modules) {
core/modules/field/tests/src/Kernel/FieldTypePluginManagerTest.php: protected function enableAllCoreModules() {
core/modules/locale/tests/src/Functional/LocaleUpdateTest.php: public function testEnableUninstallModule(): void {
core/modules/migrate/tests/src/Kernel/Plugin/MigrationProvidersExistTest.php: protected function enableAllModules() {
core/modules/migrate_drupal/tests/src/Traits/ValidateMigrationStateTestTrait.php: protected function enableAllModules() {
core/modules/system/src/Form/ModulesEnabledTrait.php: protected function modulesEnabledConfirmationMessage(array $modules): PluralTranslatableMarkup {
core/modules/system/src/Form/ModulesEnabledTrait.php: protected function modulesFailToEnableMessage(array $modules, PreExistingConfigException $exception): PluralTranslatableMarkup {
core/modules/system/src/Form/ModulesEnabledTrait.php:trait ModulesEnabledTrait {
core/modules/system/tests/src/Functional/Module/DependencyTest.php: public function testModuleEnableOrder(): void {
core/modules/system/tests/src/Functional/System/DatabaseDriverProvidedByModuleTest.php: public function testDatabaseDriverIsProvidedByModuleButTheModuleIsNotEnabled(): void {
core/modules/system/tests/src/FunctionalJavascript/OffCanvasTestBase.php: protected function enableTheme($theme) {
core/modules/views/tests/src/Functional/ViewTestBase.php: protected function enableViewsTestModule() {
core/modules/views_ui/tests/src/FunctionalJavascript/PreviewTest.php: protected function enableViewsTestModule() {
core/tests/Drupal/KernelTests/Core/Theme/StableLibraryOverrideTestBase.php: protected function enableVisibleAndStableCoreModules(): void {
core/tests/Drupal/KernelTests/KernelTestBase.php: private static function getModulesToEnable($class) {
core/tests/Drupal/KernelTests/KernelTestBase.php: protected function enableModules(array $modules) {
core/tests/Drupal/KernelTests/KernelTestBaseDatabaseDriverModuleTest.php: public function testDatabaseDriverModuleEnabled(): void {
core/tests/Drupal/KernelTests/KernelTestBaseTest.php: public function testDatabaseDriverModuleEnabled(): void {
core/tests/Drupal/Tests/Core/Extension/ModuleHandlerTest.php: public function testImplementsHookModuleEnabled(): void {
core/tests/Drupal/Tests/Core/Extension/ModuleHandlerTest.php: public function testInvokeModuleEnabled(): void {
core/tests/Drupal/Tests/Core/Update/UpdateRegistryTest.php: public function testGetPendingUpdateFunctionsWithLoadedModulesButNotEnabled(): void {

Remaining tasks

Make child issues that are scope according to the guidelines → .

User interface changes

API changes

Data model changes

Release notes snippet

🐛 Bug report

Status

Active

Version

11.0 🔥

Component

System →

Last updated 7 days ago

No maintainer

Created by

🇺🇸United States jhodgdon Spokane, WA, USA

Live updates comments and jobs are added and updated live.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment 9 months ago →
🇳🇿New Zealand quietone

Comment 4 months ago →

🇳🇿New Zealand quietone

The commands I used to search for classes, traits and methods to change.

git grep -i "^.*function.*module.*enable.*(" -- '*.php'
git grep -i "^.*function.*theme.*enable.*(" -- '*.php'
git grep -i "^.*function.*enable.*theme.*(" -- '*.php'
git grep -i "^.*function.*enable.*module.*(" -- '*.php'
git grep -i "^class.*enable.*module.*(" -- '*.php'
git grep -i "^class.*enable.*theme.*(" -- '*.php'
git grep -i "^class.*theme.*enable.*(" -- '*.php'
git grep -i "^class.*module.*enable.*(" -- '*.php'
git grep -i "^trait.*enable.*module.*{" -- '*.php'
git grep -i "^trait.*enable.*theme.*{" -- '*.php'
git grep -i "^trait.*theme.*enable.*{" -- '*.php'
git grep -i "^trait.*module.*enable.*{" -- '*.php'

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024