- Assigned to Grevil
- 🇩🇪Germany Anybody Porta Westfalica
@Grevil: If not too complicated, please make the Service Worker module a separate module. The PWA with manifest should be the main module, so service worker module can be enabled / disabled, if not needed.
I hope they are already decoupled in large parts. Perhaps @_nod will one day proceed with the separate serviceworker module, so we can move that one out entirely.
- 🇩🇪Germany Anybody Porta Westfalica
PS: Another alternative would be to be able to disable service worker by a flag (checkbox) in the settings, but I think a submodule would be more straightforward!
- 🇩🇪Germany Grevil
Another alternative would be to be able to disable service worker by a flag (checkbox) in the settings, but I think a submodule would be more straightforward!
This is issue mainly wants to make the manifest.json optional, not the service worker. Although the problem with the service worker is, that it currently doesn't work as desired. There are several issues with its implementation (see 🐛 [META][pwa_service_worker] Refactor 'pwa_service_worker' implementations and flaws Needs work ). So in our use case we only want to use the manifest.json and make the service worker optional.
@Anybody and I discussed this quite a bit internally, and we came to the conclusion, that the "heart" of a PWA, lies in the manifest. The service worker itself, which "only" provides the offline functionality of the app, is only recommended and doesn't make a Website a PWA. Furthermore, it isn't one of the 'install criterias' for a PWA (anymore):
https://web.dev/install-criteria/#criteria (Atleast for chrome).Meaning, I will create a follow-up issue to decouple the manifest and service worker through "submoduling", but instead of having the service worker functionality inside the main module, the manifest functionality will reside in the main module.
This issue can stay open for the future, so if anyone is interested, they can figure out a way to make the manifest and service worker operate on their own, without any dependencies on each other.
- Issue was unassigned.
- 🇩🇪Germany Grevil
Here is the follow up issue: 📌 Decouple service worker from manifest through a dedicated "service worker submodule" Active .