Missing cache contexts for almost all configurable language types

Open on Drupal.org →

Created on 5 October 2020, over 3 years ago

Updated 16 February 2024, 4 months ago

Problem/Motivation

On /admin/config/regional/language/detection enable the Customize %language_name language detection to differ from Interface text language detection settings checkbox. Custom menu link content will crossbleed languages.

Steps to reproduce

Have at least two languages, create a menu with UI links, translate it, place the block, enable language_content to be a configurable type observe changing the language won't change the menu language.

Proposed resolution

This needs to be addressed as widely as possible: add the right language types to the default render contexts.

Remaining tasks

Agree, test, commit.

User interface changes

API changes

Data model changes

Release notes snippet

🐛 Bug report

Status

Needs work

Version

11.0 🔥

Component

Last updated about 6 hours ago

Maintained by
🇺🇸United States @effulgentsia
🇺🇸United States @moshe weitzman

Created by

🇨🇦Canada Charlie ChX Negyesi 🍁Canada

Live updates comments and jobs are added and updated live.

Needs change record
A change record needs to be drafted before an issue is committed. Note: Change records used to be called change notifications.

Needs release note
The major change should have a special release note written to summarize the importance of the change. See Write a release note for an issue.

Bug Smash Initiative

Needs issue summary update
Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

Incomplete comments

Sign in to follow issues

Merge Requests

!6626Missing cache contexts for almost all configurable language types
Open
🇺🇸United States dww
updated 4 months ago

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment 4 months ago →
🇺🇸United States dww
This came up as a random daily triage target in #bugsmash.

Looks and sounds like this is definitely still a bug. There's unaddressed feedback that needs work. The tests could be cleaned up now that we've got the new traits from 📌 Use the API to set up languages in tests that are not specifically testing the language form Fixed . The summary needs an update to clarify the proposed change.
Merge request !6626fix(language): #3174819 Missing cache contexts for almost all configurable language types → (Open) created by dww
Comment 4 months ago →
🇺🇸United States dww
Moved #17 into https://git.drupalcode.org/project/drupal/-/merge_requests/6626 since that's now required for core development.
Pipeline finished with Failed
4 months ago
Total: 545s
#96235
Comment 4 months ago →
🇺🇸United States dww
MR had a real Kernel test failure at https://git.drupalcode.org/issue/drupal-3174819/-/jobs/829562 for the new LanguageServiceProviderTest, precisely because it wasn't setting up the language correctly. Porting it to use LanguageTestTrait and that test now passes locally.
Pipeline finished with Failed
4 months ago
Total: 193s
#96247
Pipeline finished with Success
4 months ago
Total: 489s
#96248

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024