Provide option label as computed field property

Reviewing the code

public function getValue()
1. think this will need to be typehinted

public static function propertyDefinitions(FieldStorageDefinitionInterface $field_definition)
2. same

Seeing #16 wonder if we need to rethink this solution what do you think @joachim? Did something change I mean.

I've since discovered that you can get option labels using the https://www.drupal.org/project/jsonapi_schema → module.

A computed field property seems like the right solution within the space of the entity and field system. I have no idea why JSONAPI module doesn't return computed or internal properties, but that's a discussion for another issue.

public function getValue()
1. think this will need to be typehinted

public static function propertyDefinitions(FieldStorageDefinitionInterface $field_definition)
2. same

Why do they need to be "typehinted"? These are interface methods and they fully correspond to the interface method signature.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

I moved the latest patch to the merge request. Also fixed a bug due to which allowed_values_function was not called, since the values were taken directly from the configuration, and not through the options_allowed_values function.

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Adde some comments in the MR

kksandr → closed merge request !6177