- π¬π§United Kingdom aaron.ferris
Another +1 for this feature request
- Status changed to Needs review
almost 2 years ago 1:50pm 17 May 2023 - last update
almost 2 years ago 13 pass - last update
almost 2 years ago 13 pass - Status changed to RTBC
over 1 year ago 1:20am 27 July 2023 - π―π΅Japan tyler36 Osaka
Confirmed working on Drupal
10.1
## Test
- Install and enable Content_lock module.
- Install and enable admin_toolbar module.
- Login as administrator
- Hover of "Content" menu to reveal options.- Enable patch
- Hover of "Content" menu to reveal options.
- last update
over 1 year ago 13 pass - π¬π§United Kingdom aaron.ferris
Attaching patch with correct description....
- π―π΅Japan tyler36 Osaka
Noticed I didn't include the patch number I tested so update my comment.
@arron.ferris is #7 just a file rename?
- π¬π§United Kingdom aaron.ferris
No, it is also a βdescriptionβ update as the original patch had a wrong description
- π―π΅Japan tyler36 Osaka
@aaron.ferris yeah, sorry. You are right. Was tired and missed it.
- π¬π§United Kingdom aaron.ferris
Not at all, it was my bad in the first place :)
- π¬π§United Kingdom malcomio
The patch on #7 is working as expected for me.
+1 for RTBC
- Status changed to Needs work
about 1 year ago 1:17am 20 March 2024 - π¬π§United Kingdom alexpott πͺπΊπ
We can configure this in the view rather than hardcoding it in the module's menu links files.
- π¬π§United Kingdom aaron.ferris
Thanks @alexpott
Attaching a patch.
- Status changed to Needs review
about 1 year ago 11:18am 20 March 2024 - Status changed to Needs work
about 1 year ago 12:40pm 20 March 2024 - π¬π§United Kingdom alexpott πͺπΊπ
+++ b/config/optional/views.view.locked_content.yml @@ -716,14 +716,14 @@ display: + type: normal
Needs to be a tab
Also can this be convert to use an MR - see the create issue fork stuff at the tope of the list. That means our tests will run.
I don't think an update function is necessary here - new sites will get the goodness and old sites can just edit the view and be done. We could load the view and see if it has a menu and set it up in a post update if we like though.
- π¬π§United Kingdom aaron.ferris
Is tab right? The specific change from me is to get the item into the admin menu, what am I missing?
- Merge request !19Issue #3172526: Add a menu tab to the locked content view β (Closed) created by aaron.ferris
- Merge request !20Issue #3172526: Add a menu tab to the locked content view β (Merged) created by aaron.ferris
- π¬π§United Kingdom aaron.ferris
Converted to MR as requested, changed to a tab for the initial reason for this ticket.
- Status changed to Needs review
about 1 year ago 9:25am 21 March 2024 - Status changed to RTBC
about 1 year ago 5:51pm 21 March 2024 - π¬π§United Kingdom alexpott πͺπΊπ
This works great but we need to fix π PHP Exception on overview / Add default config Needs work first otherwise the tab just produces an exception.
- πͺπΈSpain penyaskito Seville π, Spain πͺπΈ, UTC+2 πͺπΊ
π PHP Exception on overview / Add default config Needs work is ready for review to unblock this.
I've re-exported the view with core 10.3.x which alters the order of the views config keys, so might need a reroll :_( Worth in the long run I guess.
- π¬π§United Kingdom alexpott πͺπΊπ
Added test coverage and re-based MR on top of HEAD after the blocker has been merged. This is good to go.
-
alexpott β
committed 155c2f31 on 8.x-2.x authored by
aaron.ferris β
Issue #3172526 by aaron.ferris, alexpott, andy_w, tyler36: Add tasks...
-
alexpott β
committed 155c2f31 on 8.x-2.x authored by
aaron.ferris β
- Status changed to Fixed
about 1 year ago 1:04pm 27 March 2024 Automatically closed - issue fixed for 2 weeks with no activity.