Claro Shortcuts star fails WCAG Use of Color and Non-text contrast

Created on 18 September 2020, over 4 years ago
Updated 20 January 2023, about 2 years ago

Problem

The shortcuts star icon doesn't satisfy WCAG Success Criteria 1.4.1 "Use of Color", or 1.4.11 "Non-text contrast".

  • The grey outline of the star is too faint. It has a contrast ratio of just 2.78:1 against the grey page background.
  • The yellow fill isn't sufficiently distinguishable from the transparent fill. The contrast between the yellow and the grey page background is 1.29:1.
  • The yellow-fill is the only indication of state. On it's own, it isn't a reliable signifier. Even if these did have good contrast in the full-colour situation, the state can still be difficult for some users to notice: users with a colour vision impairment, or other visual impairments, or who have adjusted the colour space in some way, or where the screen is overpowered by ambient light.
  • When a Windows high-contrast theme is used, the star remains the same colour. We cannot rely on either the grey outline or the yellow fill to be distinguishable from the page background, because we cannot know what the background colour will be.
  • The Star is missing entirely in IE 11 when a Windows High Contrast theme is used. It's a CSS background image, and it gets stripped out by the browser. Users cannot perceive, operate, or understand it; they likely won't know it's there at all.
πŸ› Bug report
Status

Needs work

Version

10.1 ✨

Component
ShortcutΒ  β†’

Last updated 15 days ago

  • Maintained by
  • πŸ‡¨πŸ‡¦Canada @jibran
Created by

πŸ‡ΊπŸ‡ΈUnited States dyannenova

Live updates comments and jobs are added and updated live.
  • Accessibility

    It affects the ability of people with disabilities or special needs (such as blindness or color-blindness) to use Drupal.

Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡¨πŸ‡¦Canada mgifford Ottawa, Ontario
  • πŸ‡¨πŸ‡¦Canada mgifford Ottawa, Ontario

    My mistake on tagging this 131. I should have gotten back to Andrew on that sooner.

  • Assigned to kentr
  • πŸ‡ΊπŸ‡ΈUnited States kentr Durango, CO

    I'm going to try to move the MR forward a little.

    Adding Needs issue summary update because the IS mentions IE11 and AFAIK Drupal dropped support for IE11.

  • πŸ‡ΊπŸ‡ΈUnited States kentr Durango, CO

    There were merge conflicts when updating the existing MR branch, so here's a new MR against 11.x.

    Some comments

    1. I went back to the non-concentric fill for the "remove" states as specified by @ckrina's comment #16.
    2. For the "add, hover" state, the previous MR had a solid fill for forced-colors: active.
      That wasn't in @ckrina's screenshots, and due to the + above the star in the Claro icons I wondered if it is necessary. So I left the fill empty for now as shown in the screenshots.
    3. Inside the CSS url() function, the SVG with a forced-colors: active media query embedded in a style element did not display the LinkText color as expected.
      However, there are many instances in core of using mask-image for forced-colors: active, so I went with that method.
    4. For the time being, I've put the same icons into both Claro and the shortcut module.
      I suggest creating a lower-priority followup to refine the shortcut module's icons since they'll appear on Olivero (which has different blues).

    These screenshots are from Mac Firefox in standard mode and with browser.display.document_color_use set to 2.

    Needs manual testing with & without forced-colors / WHCM. I will update the IS with details.

  • πŸ‡ΊπŸ‡ΈUnited States kentr Durango, CO

    kentr β†’ changed the visibility of the branch issue-3171726 to hidden.

  • πŸ‡ΊπŸ‡ΈUnited States kentr Durango, CO

    kentr β†’ changed the visibility of the branch 3171726-claro-shortcuts-star to hidden.

  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    Have not reviewed but previously tagged for issue summary update

    Tried to cleanup what I assume are old tags.

  • πŸ‡ΊπŸ‡ΈUnited States kentr Durango, CO

    I'm working on the IS update.

  • πŸ‡ΊπŸ‡ΈUnited States kentr Durango, CO

    Updated the IS, included testing notes, and attached the screenshots that didn't save for #57.

  • πŸ‡ΊπŸ‡ΈUnited States kentr Durango, CO

    Forgot to change status / remove IS update.

Production build 0.71.5 2024