- last update
over 1 year ago 2 pass - π»π³Vietnam chuyenlv
Tested with Drupal 10 and I see some errors:
- Deprecated function: Creation of dynamic property Drupal\tablefield\Plugin\Field\FieldFormatter\TablefieldFormatter::$ModuleHandler is deprecated
- Deprecated function: Creation of dynamic property Drupal\tablefield\TableValue::$value is deprecated
I create the patch to fix these errors. - last update
over 1 year ago 2 pass - π«π·France Grimreaper France π«π·
Hi,
Thanks for the patch comment 5, it solved the warnings.
- π¨π¦Canada dylan donkersgoed London, Ontario
The clean-code-deprecated-dynamic-property-3170043-5.patch patch no longer applies to the latest dev/2.5-rc1 versions because the moduleHandler property name has been fixed. Attaching a new patch which includes only the setValue fix.
- First commit to issue fork.
- πΊπΈUnited States erutan
erutan β changed the visibility of the branch 8.x-2.x to hidden.
-
erutan β
committed eb087153 on 8.x-2.x
Issue #3170043 by s.abbott, chuyenlv, dylan donkersgoed: Code cleanup
-
erutan β
committed eb087153 on 8.x-2.x
- πΊπΈUnited States erutan
Patch #7 applies cleanly to dev / RC2 and solves the issue. This is the most important patch,
The following two patches have already been implemented:
3170043-code-cleanup--fix-indentation-3.patch
3170043-code-cleanup--fix-capitalization-3.patchThe following patch applies cleanly:
3170043-code-cleanup--add-return-documentation-3.patch
The following patch has been confirmed that there is no add_row property and applies cleanly:
3170043-code-cleanup--remove-unused-property-3.patch
- π¨π¦Canada Liam Morland Ontario, CA π¨π¦
Should this be cherry-picked onto branch 3.0.x?
- πΊπΈUnited States erutan
The bugfix should be universally applied, the code cleanup is trivial but universal. It'd be nice to not have future patches have to deal with it (the capitalization of moduleHandler was fixed at least 3 times in different patches).
-
liam morland β
committed fea05d62 on 3.0.x authored by
erutan β
Issue #3170043 by s.abbott, chuyenlv, dylan donkersgoed: Code cleanup
-
liam morland β
committed fea05d62 on 3.0.x authored by
erutan β
Automatically closed - issue fixed for 2 weeks with no activity.