Contrib.social
Created on 9 September 2020, about 4 years ago
Updated 22 June 2023, over 1 year ago

Problem/Motivation

While working on several other patches/issues I stumbled across several bits of code I wanted to clean up, but none of the changes fit within the other patches or were big enough issues to warrant their own, so I'm bundling them all here (patches will follow).

Steps to reproduce

N/A

Proposed resolution

N/A

Remaining tasks

RTBC & merge

User interface changes

None.

API changes

  1. Renamed the misspelled 'TablefieldFormatter::$ModuleHandler' to the expected 'TablefieldFormatter::$moduleHandler'
  2. Removed the default value of the unused property '#add_row'

Data model changes

N/A

📌 Task
Status

Needs review

Version

2.0

Component

Code

Created by

s.abbott

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.1 & MySQL 8
    last update over 1 year ago
    2 pass
  • Comment over 1 year ago →
    🇻🇳Vietnam chuyenlv

    Tested with Drupal 10 and I see some errors:
    - Deprecated function: Creation of dynamic property Drupal\tablefield\Plugin\Field\FieldFormatter\TablefieldFormatter::$ModuleHandler is deprecated
    - Deprecated function: Creation of dynamic property Drupal\tablefield\TableValue::$value is deprecated
    I create the patch to fix these errors.

  • Open in Jenkins → Open on Drupal.org →
    Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
    last update over 1 year ago
    2 pass
  • Comment about 1 year ago →
    🇫🇷France Grimreaper France 🇫🇷

    Hi,

    Thanks for the patch comment 5, it solved the warnings.

  • Comment 9 days ago →
    🇨🇦Canada dylan donkersgoed London, Ontario

    The clean-code-deprecated-dynamic-property-3170043-5.patch patch no longer applies to the latest dev/2.5-rc1 versions because the moduleHandler property name has been fixed. Attaching a new patch which includes only the setValue fix.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024