- Merge request !38Issue #3168732: Allow to alter settings to add settings per entity bundle → (Open) created by dieterholvoet
- First commit to issue fork.
- last update
about 2 years ago 29 pass, 2 fail - First commit to issue fork.
- Status changed to RTBC
5 months ago 9:50am 9 April 2025 - 🇫🇷France dpiet
Updated patch in order to use in
composer.json
, tested successfully on Drupal 11.1.5. - 🇫🇷France mably
Just wondering why the
&& $is_cloneable
conditions have been removed.An idea anyone?
- 🇫🇷France mably
In fact, doesn't seem to work if the checkbox are hidden, investigating.
- Merge request !96Issue #3168732 by dieterholvoet, beloglazov91, mably, skorzh, rajeshreeputra: Allow to alter settings to add settings per entity bundle → (Merged) created by mably
- 🇫🇷France mably
Definitely not the best way to handle bundle value. Working on it.
- 🇫🇷France mably
We finally decided to simply display all the bundles on the configuration screen instead of using a hook:
What do you think?
- 🇫🇷France mably
A new configuration option has been added, allowing to enable/disable the bundles feature at will:
- 🇫🇷France mably
FYI it has been successfully deployed on a high traffic website (bordeaux.fr) for several weeks.
- Status changed to Needs review
9 days ago 10:21am 1 September 2025 - First commit to issue fork.
- 🇸🇮Slovenia deaom
Added a check as when you first save the settings, the form_settings are empty/null, so array_merge returns an error, as the first element is null (TypeError: array_merge(): Argument #1 must be of type array, null given in array_merge() (line 119 of /contrib/entity_clone/src/EntityCloneSettingsManager.php).) and thus preventing the settings form to be saved.
After the first save, the form_settings is populated.
This can be tested by installing the module and saving the settings, or if the module is already installed first uninstalling it and then installing again and saving the settings.
Leaving to Needs review, but based on the comments can be merged. - 🇸🇮Slovenia deaom
The action test that is causing test failures is still removed here, but should be added back in once 💬 Add action module as dev dependency. Active is merged.
- 🇸🇮Slovenia deaom
Branch is re-based the action test is added back in and the tests are passing. Leaving status as is, but from my POV can be merged.
- 🇫🇷France mably
Patch has been deployed in production for several months now. Everything is still running fine.
-
rajeshreeputra →
committed ec33469d on 2.x authored by
mably →
Issue #3168732 by dieterholvoet, beloglazov91, mably, skorzh,...
-
rajeshreeputra →
committed ec33469d on 2.x authored by
mably →
Now that this issue is closed, please review the contribution record.
As a contributor, attribute any organization helped you, or if you volunteered your own time.
Maintainers, please credit people who helped resolve this issue.