Provide theme support for Claro

Hi!

I'm using this patch on version Drupal core 10.1.2 and Layout Builder Modal 8.x-1.2.

My modal needs 2 clicks to be openned and I receive the next error on the first click:

ajax.js?v=10.1.2:1119 An error occurred during the execution of the Ajax response: The following files could not be loaded: /corporativo/modules/contrib/layout_builder_modal/theme/claro/css/table.css?s0icd922

I noticed that is missspelled and is missing an 's' after 'table.css'. It should be 'tables.css'.

I'm attaching the new patch. Is exactly the same, with this error fixed.

Thanks!

Just tried the patch #22, it doesn't work for me.

First the library is not even added for me, it might be a different bug. I suspect that because the configure block is an ajax request, the #attached from the form are not added into the page.

But even when adding manually that into a preprocess_page, the styling is definitely not great.
$variables['#attached']['library'][] = 'layout_builder_modal/claro';
I noticed some changes though, like fixing the z-index of the modal, or button styles, but lots of it doesn't look good, wrong color of the modal header, close button invisible, selects/checkboxes are not styled.

+1! How can this show the option to use "Administration (Seven)" when it's not even installed on my site?!
And shouldn't the default theme be the default drupal core admin theme, ie. Claro?

Also, why do we need to provide custom CSS when in core we already have everything styled & coherent?
Dialogs are used by Claro so I don't understand why we should override it with ugly jQuery-like dialogs.
Maybe it's a matter of the HTML & CSS classes produced by this module?

I think we should align those.

layout_builder_modal mess with styles:

example of a beautiful dialog provided by core with claro theme:

PS: yes, I'm using the admin theme when editing content, so that should be used on the modal form as well.

+1! How can this show the option to use "Administration (Seven)" when it's not even installed on my site?!
And shouldn't the default theme be the default drupal core admin theme, ie. Claro?

Also, why do we need to provide custom CSS when in core we already have everything styled & coherent?

For all the reasons stated here, this is why the module Layout Builder iFrame Modal is preferable! See https://www.drupal.org/project/layout_builder_modal/issues/3163024#comme... ✨ Provide theme support for Claro Needs work

If there is a reason why you can't switch to that module, please explain!

2 cents here. I have been using layout builder iframe modal until we ran into AJAX issues of adding media to the blocks in the modal. Then we switched back to this module and the issue was gone. I don't remember all the details but basically there was an error in the console and the media wasn't attached. It started with updates to D10 for D9 the module worked just fine. So I wonder if iFrame isn't going to work in all situations

I don't remember all the details but basically there was an error in the console and the media wasn't attached. It started with updates to D10 for D9 the module worked just fine.

Hrm... our team uses Layout Builder iFrame Modal and has many components that involve media uploads, and haven't encountered any issues. Our setup could be different than yours, however. If it's not too much trouble to test again and see if you can reproduce, and then report any issues in the Layout Builder iFrame Modal queue, that would be awesome. If it is a generalized issue, fixing it in that module could be an easier solution than moving this issue for Layout Builder Modal forward.