- Issue created by @dpi
- π«π·France Nono95230
Add admin_route option to true, for the following routes :
- 'entity.block_content.revision'
- 'entity.block_content.version_history'
- 'entity.block_content.revision_revert_form'
- 'entity.block_content.revision_revert'
- π²π¦Morocco jamaoui
Following the application of the patch I saw that we have a small problem for the detail part of the revision, since the theme activated is the admin theme the templates used for the theme of the site are not available the thing that may not display the block perfectly.
Via this patch I propose a small refactoring of the work done by @Nono95230 with the deletion of the page view revision of the theme admin.
Add admin_route option to true, for the following routes :
'entity.block_content.version_history'
'entity.block_content.revision_revert_form'
'entity.block_content.revision_revert' The last submitted patch, 3: block_content_revision_ui-show-admin-pages-in-admin-theme-3160479-3.patch, failed testing. View results β
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- πΊπΈUnited States capysara
I think there was a typo (extra line) in the patch. I applied the patch via composer and got an error:
PHP Parse error: Unclosed '{' on line 14 in /var/www/html/web/modules/contrib/block_content_revision_ui/src/Routing/BlockContentRevisionUiRouteSubscriber.php on line 33
I just removed the extra empty line above the final closing '{' so that it gets included in the patch.
After applying the new patch, I get the Revision table in the admin theme as expected.
- π¦πΊAustralia dpi Perth, Australia
This issue is in no way greater than normal priority.
The patch is still missing configurability, per IS.
- πΊπΈUnited States capysara
Ah I just glossed over the "config toggle" in the IS.
Do you agree with the change in #3 β¨ Add configuration to optionally show/toggle admin pages in Admin theme Needs work ?
deletion of the page view revision
- πΊπΈUnited States scottcollier Austin, TX
Renamed patch to match comment. Same patch in #13
- πΊπΈUnited States capysara
Is this module obsolete now that https://www.drupal.org/project/drupal/issues/1984588 β¨ Add Block Content revision UI Fixed is fixed?
- πΊπΈUnited States firewaller
After upgrading to Drupal core 10.1, this patch seems to be unnecessary.
As to whether this entire module is obsolete due to the core changes, for the most part yes, however this module does introduce certain permissions that don't seem to be covered by core (i.e. revert block_content BLOCK_TYPE revisions, view block_content BLOCK_TYPE history, and view block_content BLOCK_TYPE revisions).