Fix the issues reported by phpcs

Fixed coding standards using phpcs for Drupal and DrupalPractice standards.

Please check and merge pr.

Thanks

See my previous comment. The issue summary has not been updated.

The MR does not correctly change the files.

 /**
- * Class DefaultController.
+ * Class of DefaultController.
  */

That is not what a documentation comment for a class should say. Adding of is not sufficient.

-  /**
-   * {@inheritdoc}
-   */
-  public function validateForm(array &$form, FormStateInterface $form_state) {
-    parent::validateForm($form, $form_state);
-  }
-

That change is not required by the coding standards.

-    //sleep(30);
+    // sleep(30);.

There is no need to add a period to commented out code.

The issue summary still needs to be updated.

As for the MR, it still uses Class of.

Issue summary Updated.
Please review.

resolved some of this error
still few warnings and errors are left

FILE: C:\wamp64\www\contribution\block_list_override\README.txt
----------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
14 | WARNING | Line exceeds 80 characters; contains 108 characters
43 | WARNING | Line exceeds 80 characters; contains 303 characters
----------------------------------------------------------------------

FILE: C:\wamp64\www\contribution\block_list_override\src\Controller\DefaultController.php
-----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
14 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
-----------------------------------------------------------------------------------------------------------------

FILE: C:\wamp64\www\contribution\block_list_override\src\Form\SettingsForm.php
-------------------------------------------------------------------------------------------------------------------------
FOUND 14 ERRORS AND 16 WARNINGS AFFECTING 16 LINES
-------------------------------------------------------------------------------------------------------------------------
13 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
62 | WARNING | Translatable strings must not begin or end with white spaces, use placeholders with t() for variables
62 | ERROR | Concatenating translatable strings is not allowed, use placeholders instead and only one string literal
74 | WARNING | Translatable strings must not begin or end with white spaces, use placeholders with t() for variables
74 | ERROR | Concatenating translatable strings is not allowed, use placeholders instead and only one string literal
87 | WARNING | Translatable strings must not begin or end with white spaces, use placeholders with t() for variables
87 | ERROR | Concatenating translatable strings is not allowed, use placeholders instead and only one string literal
92 | WARNING | Translatable strings must not begin or end with white spaces, use placeholders with t() for variables
92 | ERROR | Concatenating translatable strings is not allowed, use placeholders instead and only one string literal
99 | WARNING | Translatable strings must not begin or end with white spaces, use placeholders with t() for variables
99 | ERROR | Concatenating translatable strings is not allowed, use placeholders instead and only one string literal
102 | WARNING | Translatable strings must not begin or end with white spaces, use placeholders with t() for variables
102 | ERROR | Concatenating translatable strings is not allowed, use placeholders instead and only one string literal
108 | WARNING | Translatable strings must not begin or end with white spaces, use placeholders with t() for variables
108 | ERROR | Concatenating translatable strings is not allowed, use placeholders instead and only one string literal
127 | WARNING | Translatable strings must not begin or end with white spaces, use placeholders with t() for variables
127 | ERROR | Concatenating translatable strings is not allowed, use placeholders instead and only one string literal
143 | WARNING | Translatable strings must not begin or end with white spaces, use placeholders with t() for variables
143 | ERROR | Concatenating translatable strings is not allowed, use placeholders instead and only one string literal
150 | WARNING | Translatable strings must not begin or end with white spaces, use placeholders with t() for variables
150 | ERROR | Concatenating translatable strings is not allowed, use placeholders instead and only one string literal
164 | WARNING | Translatable strings must not begin or end with white spaces, use placeholders with t() for variables
164 | ERROR | Concatenating translatable strings is not allowed, use placeholders instead and only one string literal
174 | WARNING | Translatable strings must not begin or end with white spaces, use placeholders with t() for variables
174 | ERROR | Concatenating translatable strings is not allowed, use placeholders instead and only one string literal
181 | WARNING | Translatable strings must not begin or end with white spaces, use placeholders with t() for variables
181 | ERROR | Concatenating translatable strings is not allowed, use placeholders instead and only one string literal
188 | WARNING | Translatable strings must not begin or end with white spaces, use placeholders with t() for variables
188 | ERROR | Concatenating translatable strings is not allowed, use placeholders instead and only one string literal
199 | WARNING | Possible useless method overriding detected
-------------------------------------------------------------------------------------------------------------------------

FILE: C:\wamp64\www\contribution\block_list_override\tests\src\Functional\BlockListOverrideTest.php
---------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------
92 | WARNING | Line exceeds 80 characters; contains 82 characters
---------------------------------------------------------------------------------------------------

The last submitted patch, 22: phpcs_fix.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Hi,

MR #23 applied successfully.

Admin@DESKTOP-252TO6V MINGW64 ~/Desktop/projects/drupal/web/modules/block_list_override (1.0.x)
$ curl https://git.drupalcode.org/project/block_list_override/-/merge_requests/3.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 22431    0 22431    0     0  52231      0 --:--:-- --:--:-- --:--:-- 52286
patching file README.txt
patching file block_list_override.install
patching file block_list_override.links.menu.yml
patching file config/install/block_list_override.settings.yml
patching file src/BlockListOverride.php
patching file src/Controller/DefaultController.php
patching file src/Controller/LayoutController.php
patching file src/Form/SettingsForm.php
patching file src/LayoutPluginAlter.php
patching file src/PluginAlter.php
patching file tests/src/Functional/BlockListOverrideTest.php

No errors remaining.

Admin@DESKTOP-252TO6V MINGW64 ~/Desktop/projects/drupal/web/modules
$ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml block_list_override/

Admin@DESKTOP-252TO6V MINGW64 ~/Desktop/projects/drupal/web/modules
$