Style primary search form's -webkit-search-cancel-button within desktop and mobile navigation

Comment about 2 years ago →
needs-review-queue-bot
The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
Status changed to Needs review almost 2 years ago4:25am 9 May 2023
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update almost 2 years ago
29,380 pass
Comment almost 2 years ago →
🇮🇳India gauravvvv Delhi, India
Patch #41, no longer applies to 10.1.x. here is a quick re-roll. please review
Comment almost 2 years ago →
🇮🇳India ravi kant Jaipur
Patch #45 is applying to 10.0.9 and 10.1.x. as accepted.
Assigned to Bushra Shaikh
Comment almost 2 years ago →
🇮🇳India Bushra Shaikh
Status changed to RTBC almost 2 years ago11:48am 10 May 2023
Comment almost 2 years ago →
🇮🇳India Bushra Shaikh
Verified and tested patch#45 on Drupal 10.1.X version, Patch applied successfully and looks good to me.

Test Result:
The contrast changed, styled to a light gray X.

Can be moved to RTBC +1
Issue was unassigned.
Comment almost 2 years ago →
🇮🇳India Bushra Shaikh
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update almost 2 years ago
29,383 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update almost 2 years ago
29,388 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update almost 2 years ago
29,387 pass, 2 fail
Comment almost 2 years ago →
System Message
The last submitted patch, 45: 3153475-45.patch, failed testing. View results →
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update almost 2 years ago
29,436 pass
Status changed to Needs review almost 2 years ago9:16am 23 June 2023
Comment almost 2 years ago →
🇮🇳India sagarchauhan
Random test failure. Moving to review.
Status changed to RTBC almost 2 years ago9:20am 23 June 2023
Comment almost 2 years ago →
🇮🇳India sagarchauhan
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update almost 2 years ago
29,436 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update almost 2 years ago
29,441 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update almost 2 years ago
29,442 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update almost 2 years ago
29,443 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update almost 2 years ago
29,443 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update almost 2 years ago
29,443 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update almost 2 years ago
29,439 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update almost 2 years ago
29,439 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update almost 2 years ago
29,443 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update almost 2 years ago
29,444 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update almost 2 years ago
29,446 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update almost 2 years ago
29,446 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update almost 2 years ago
29,446 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update almost 2 years ago
29,446 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update almost 2 years ago
29,450 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update almost 2 years ago
29,453 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
29,454 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
29,455 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
29,456 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
29,457 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
29,458 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
12:22
8:34
Running
Status changed to Needs work over 1 year ago2:07am 9 August 2023
Comment over 1 year ago →
🇳🇿New Zealand quietone
The issue summary here is very brief but easy to understand what is being changed. I did add the template in case it is needed.

I read through the comments and found an item that has not been responded to, #25.1. I am adding that as a remaining step in the issue summary.

Setting NW for the point to be addressed.

Style primary search form's -webkit-search-cancel-button within desktop and mobile navigation

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments & Activities