Set Block Category to Bundle in block_content module

I think this is a great improvement, but we should add a change record here to convey to site owners that this is changing.

And probably a release note snippet too.

Requeued tests as the last fail was a random and was against 9.5

Took a shot at both

Ready for review again.

Updated the release note and change notice to use plain language with some help from hemingway.app (thanks @quietone for telling me about that)

This looks ready to go to me.

The last submitted patch, 25: 3153092-25.patch, failed testing. View results →

Putting back to RTBC as the failure appeared to be random.

I'm tagging this for review at a usability group meeting, in the context of the recent changes on 📌 Rename Custom Block terminology in the admin UI Fixed .

Quoting myself on 📌 Drupal Usability Meeting 2023-04-21 Needs work :

At 📌 Drupal Usability Meeting 2023-04-14 Fixed , we discussed 📌 Rename Custom Block terminology in the admin UI Fixed and recommended changing the content block category from "Custom" to "Content block". The fact that the block placement list uses the word "categories" to group blocks was part of our rational for recommending that we simply use "block types" to describe the block content module's block types, and that the term "categories" on the block placement listing and that all content blocks are grouped under a single category, creates enough of a distinction between content blocks and blocks which are provided by code and config.

I don't disagree with the changes the issue is proposing, showing which type a content block is part of I'm sure is a good thing; But if ✨ Set Block Category to Bundle in block_content module Postponed were committed it would make that distinction less clear and blur the lines, where block types would be mixed in with other categories.

So given the context, this definitely needs to be given proper consideration and direction before it is committed.

Setting back to needs review for now.

Found some issues with this.
1. Needs an upgrade path as the categories don't automatically fix themselves.
2. Think something is missing because when I try to use with layout_builder_restrictions the categories appear as separate categories but the settings do nothing. Can't exclude or include which I feel should be possible.

Going to postpone this as https://www.drupal.org/project/drupal/issues/2940755 🐛 block_content block derivatives do not scale to thousands of block_content entities Needs work may make it mute.