Node Access Rebuild never finishes (infinite loop)

I think this is actually major. Not sure how we'd write tests for it since I think it requires a race condition or similar? Also phpstan is finding the existing bug in the logic.

#42 looks good so moving back to needs review.

Wow 2008!

Updated the issue summary best I could on patch #42

Leaving the tests tag just in case but noted in the IS this may not be possible.

Applied patch #42 and ran rebuild from admin/reports/status/rebuild which completed without failure.

Change makes sense to me.

I'm triaging RTBC issues → . I read the IS and skimmed comments. It is very helpful that the proposed resolution identifies the patch being referred to. Although, the sentence is rather cryptic and I didn't understand it until I read the patch. I didn't find any unanswered questions or other work to do.

Leaving at RTBC.

+++ b/core/modules/node/node.module
@@ -1174,10 +1174,11 @@ function _node_access_rebuild_batch_operation(&$context) {
+    if (!empty($nodes[$nid])) {

Should this be isset() instead?

@kim.pepper probably, but it doesn't make a difference to this issue, as we will still increment the progress whether the node is empty or not.

Going to go ahead and commit this given it's been more or less the same fix since 2009 and has been RTBC multiple times since then.

Once again I don't see how this is testable since it depends on a race condition being triggered during node access rebuild, however it's also a good example of phpstan finding a (very old) bug.

We could open a follow-up for the empty vs. isset change, also think it's probably time to look at a NodeAccessUpdater class similar to the config update helper to try to modernize some of this and make it a bit less tied to batch.

Automatically closed - issue fixed for 2 weeks with no activity.