Votes are created when they should not

How to reproduce

Create a content type

Add Fivestar field to it with ("rated_while" => "viewing") or ("rated_while" => "editing", "allow_ownvote" => false)

Create node of that type

Result: vote is created owned by author

Expected result: no vote is created

Set "rated_while" to "viewing"

Edit the node as another user, e.g. administrator

Result: vote is created owned by user who edited the node

Expected result: no vote is created

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Open in Jenkins → Open on Drupal.org →
Core: 9.5.5 + Environment: PHP 7.3 & MySQL 5.7
last update about 1 year ago
6 pass
Open in Jenkins → Open on Drupal.org →
Core: 9.5.5 + Environment: PHP 7.3 & MySQL 5.7
last update about 1 year ago
6 pass
Comment about 1 year ago →
🇪🇸Spain eduardo morales alberti Spain, 🇪🇺
Tested on drupal 10.2.3 RTBC!
Status changed to Needs work 12 months ago3:10am 17 May 2024
Comment 12 months ago →
🇦🇺Australia fenstrat Australia
I'm not sure that any of these approaches are actually correct.

Could someone please test the fixes in 📌 Improve test coverage and add back "Allow voting" display option Needs review to see if it solves their issues here? Specifically it fixes how allow_ownvote works (it wasn't working at all when fivestar was used when viewing the entity). With #3447756 applied I cannot replicate the unneeded vote as per the "How to reproduce" steps above.

If issues persist, please outline the steps to reproduce.

How to reproduce