- Issue created by @fenstrat
- Merge request !32Improve test coverage and add back "Allow voting" display option. β (Open) created by fenstrat
44:46 19:18 Running44:31 18:19 Running- Status changed to Needs review
11 months ago 2:49am 17 May 2024 - π¦πΊAustralia fenstrat Australia
MR 32 does the following:
- Improves the test coverage, much of this was based on #3131954-26: Port tests to 8.x-1.x β but which were never included as part of that issue.
- Test reworking includes updating
FivestarTest::testViewerNonRating()
which was testing a non existentdisabled
option which was never ported from Drupal 7. This is what I've added asallow_vote
given thatdisabled
is a pretty overloaded term. - Also worth noting that
FivestarTest::testViewerNonRating()
was added to in #3190556: Illegal choice 0 in field_fivestar element for fivestar widget β , however that additionis now covered elsewhere inFivestarTest
. Aside: At a glance I can't say I understand what was achieved in #3190556 Β―\_(γ)_/Β― - Note I've pulled in some of the test changes made to
FivestarTestTrait
in #3201584-22: StarsFormatter - Add back user, smart and dual option for star display and text β as they were also needed here.
Would be nice to get this test coverage reviewed and in, at which point I'm happy to circle through other open issues and update them as needed.
- First commit to issue fork.