- last update
over 1 year ago Custom Commands Failed - 🇮🇳India gauravvvv Delhi, India
I have themed the @font-your-face view. I have attached patch for same. please review
- Status changed to Needs work
over 1 year ago 3:15pm 3 May 2023 - 🇺🇸United States bnjmnm Ann Arbor, MI
+++ b/core/themes/claro/css/components/views-ui.pcss.css @@ -574,3 +574,121 @@ details.fieldset-no-legend { +.view-fontyourface-font-manager {There is no core fontyourface view, and this entire patch is based on styling a fontyourface view. This would absolutely not be commite to core as it's styling something that isn't in core - it's something you get from a specific contrib module.
If this is the desired approach , then it should be added to https://www.drupal.org/project/fontyourface → , not core.
If you opt for a more generic solution (one that doesn't have CSS full of 'fontyourface'), it could go in core.
- Assigned to nishamukta
- 🇮🇳India nishamukta
I agree with @bnjmnm that the patch should be applied to the "fontyourface" module, not Claro, because view display appears to be an issue when this module is installed, and the issue is now tagged to version 11.x-dev, where the fontyourface module is not available; it is only available till Drupal 10. I think tagging should be corrected.