- ๐ฉ๐ชGermany Anybody Porta Westfalica
Thank you for your work here. Could this please be rerolled against 2.x as MR with tests?
- First commit to issue fork.
- Merge request !7Issue #3142776: When the source term is tagged with large number of nodes, memory exhaustion error occurs โ (Open) created by askibinski
- last update
over 1 year ago 7 pass - ๐ณ๐ฑNetherlands askibinski
Created an MR against 2.x with the patch from #18 + minor changes. The difference with #20 is mainly a separate batch method in the manager and config for the batch size. The tests still use the non-batch method.
However, since this is only an api module, I would consider all this code to be in the wrong place. The term merge module is where the UI is and the batch_set should be implemented over there. This does require a bit of splitting up of `migrateReference` in the service.
Any functional javascripts for that should also be added in term merge. - ๐ช๐ธSpain omarlopesino
The MR works fine but to get the list of entities, the entities are being loaded which may lead to memory limit reach problems IMO. I suggest to, in the batch migrate, instead of loading the entities at the beginning, get the ID list and then in the batch callback load the entity. What do you think?
- last update
over 1 year ago 7 pass - ๐ช๐ธSpain omarlopesino
I've updated the MR by loading only the entity IDs in the batch setup, and loading the entities in each batch iteration, may somebody check?
- First commit to issue fork.
- last update
10 months ago 7 pass - ๐ฌ๐งUnited Kingdom ricky@rbwebdesigns.co.uk
In agreement with the statement in #27, batch_set needs to be done outside of the batchMigrateReference function.
I've created a patch that can be applied on top of MR 7 (apologies, not familiar with MR process). It changes batchMigrateReference to getMigrateReferenceBatchOperations which returns an array of operations to use in a batch_set call outside of this module.
- ๐บ๐ฆUkraine andriy khomych
Andriy Khomych โ made their first commit to this issueโs fork.
- last update
7 months ago 7 pass - ๐บ๐ฆUkraine andriy khomych
Sorry to jump on it :) I think it makes sense to include #32 as batch (or queue) should be set outside.