Contrib.social

In High contrast mode, Dialog close button "icon" not fully centered.

Open on Drupal.org →
Created on 15 May 2020, over 4 years ago
Updated 29 April 2024, 4 months ago

Postponed on #3023311: Modal dialog style update →

Problem/Motivation

In #3023311: Modal dialog style update → it was pointed out that the high contrast mode close button "icon" is not completely centered ("icon" in quotes as high contrast mode does not load CSS background images)

Proposed resolution

The "icon" is actually borders from ::before and ::after pseudoselectors. Potential solutions are

  • Finessing the styling so it is fully centered.
  • Find another approach to creating a high-contrast compatible icon that is easier to center
  • Change the hover/focus effect so the lack of centering is less apparent. High contrast mode is already a significantly different experience, so a change to hover/focus styling is probably acceptable.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

🐛 Bug report
Status

Closed: outdated

Version

11.0 🔥

Component
Claro  →

Last updated 1 day ago

Created by

🇺🇸United States bnjmnm Ann Arbor, MI

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment over 1 year ago →
    needs-review-queue-bot

    The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

    Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

    Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

  • Status changed to Closed: outdated 4 months ago
  • Comment 4 months ago →
    🇮🇳India Gauravvv Delhi, India

    This issue is no longer reproducible, as the approach for high contrast has been changed and the icon seems to be aligned perfectly with the new approach. Attached screenshot for reference.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024