Olivero: Support wide/full width regions

Created on 24 April 2020, over 4 years ago
Updated 10 November 2023, 10 months ago

We currently have layout--content-narrow and layout--content-medium CSS classes that enable containers to stretch to a certain number of grid columns.

This task is to create two additional utility classes:

  • layout--content-wide
  • layout--content-full
πŸ“Œ Task
Status

Needs work

Version

11.0 πŸ”₯

Component
OliveroΒ  β†’

Last updated about 8 hours ago

Created by

πŸ‡§πŸ‡ͺBelgium DuneBL

Live updates comments and jobs are added and updated live.
  • CSS

    It involves the content or handling of Cascading Style Sheets.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡¦πŸ‡ΊAustralia sime Canberra

    I've updated this patch to apply to the latest core. I can see the class is being used, but the layout is not using more grid than the medium, and I'm not good enough at frontend to debug this.

  • πŸ‡¦πŸ‡ΊAustralia sime Canberra

    OK correction, it appears to be working. It still starts at column 3 but extends further to the right. I think potentially a "wide" should start at column 2.

    BTW i tested it by overriding region--content.html.twig with

    {%
      set classes = [
        'region',
        'region--' ~ region|clean_class,
        'grid-full',
        'layout--pass--content-wide',
      ]
    %}
    
    {% if content %}
      <div{{ attributes.addClass(classes) }} id="content">
        {{ content }}
      </div>
    {% endif %}
    
  • last update 10 months ago
    Composer error. Unable to continue.
  • last update 10 months ago
    30,486 pass
  • πŸ‡¦πŸ‡ΊAustralia sime Canberra

    I feel like the title is at odds with what the description/code have become.

  • Tested patch #23 and it's successfully applied the layout--pass--content-wide class is working well. The layout is now full-sized when using wide class. Attached screenshot for reference.

    Before patch

    After Patch

  • Status changed to Needs review 10 months ago
  • πŸ‡¦πŸ‡ΊAustralia sime Canberra

    @shweta__sharma It would be very good in your screenshots to use the "grid" button (it's right next to the area you highlighted) to visually show the grid.

    I think this patch is "needs work" for two reasons:

    1. because Olivero is not intended to be a base theme. So this patch is meaningless in my opinion without some way for a site builder to change the layout through settings.
    2. The second problem is the title of this issue is "wide/full width regions" and currently this patch only does wide.
  • Status changed to Needs work 10 months ago
  • πŸ‡¦πŸ‡ΊAustralia sime Canberra
  • πŸ‡¦πŸ‡ΊAustralia sime Canberra

    #17 review is still applicable

Production build 0.71.5 2024