The remaining rule are ignored on missing context

I agree that the patch is the right one, otherwise you cannot stack up rules as it will just exit the whole function before processing other rules. I think this is one of the key features why somebody would use this module.

I'm not sure about what you mean in the rest of comment #3, but I'd like to know in which situations the current code would be valid? Certainly exiting the functions without even considering all the other rules is not ideal.

From my point of view, the fix in #2 fixes the main issue.

Thanks @fjgarlin setting this RTBC based on these comments. Could someone please prepare the patch as MR?

fjgarlin → changed the visibility of the branch 3123722 to hidden.

You got it: https://git.drupalcode.org/project/theme_switcher/-/merge_requests/9/diffs

fjgarlin → changed the visibility of the branch 2.x to hidden.

MR against 2.x: https://git.drupalcode.org/project/theme_switcher/-/merge_requests/10/diffs
MR against 8.x-1.x: https://git.drupalcode.org/project/theme_switcher/-/merge_requests/9/diffs

Fixed credits and merged into both branches!

We should tag a new release in some weeks if it works for everyone. :)

Automatically closed - issue fixed for 2 weeks with no activity.