- 🇳🇴Norway zaporylie
There are some severe implications connected to this feature request
- If order were to be refreshed - the price resolver may resolve different price, different promotions can apply, tax rate can change, etc. This will impact the entire order.
- Applying promotion typically results in price change. Price change calls for adjustment of the tax adjustment
- Non-draft orders, especially orders in the final state (state_machine) should be considered immutable. If they are not, the list of allowed option should be curated and implemented on per case basis.
I think this issue boils down to an UX issue - order edit form should not expose the coupon code field.
- 🇵🇹Portugal introfini
@zaporylie You are completely correct; this is simply a UX/UI issue that could be improved.
- 🇳🇴Norway zaporylie
- Status changed to Needs review
over 1 year ago 1:39pm 8 May 2023 - last update
over 1 year ago 781 pass - 🇳🇴Norway zaporylie
Here's a patch that changes default field display options.
- 🇮🇱Israel jsacksick
I don't like this fix, you could still edit a draft order? And the coupon would be applied. Additionally on several projects I need to manually re-apply coupons on placed orders, I then have custom scripts that trigger a slightly modified version of the order refresh that doesn't involve the price recalculation.
- 🇩🇪Germany Anybody Porta Westfalica
@jsacksick I think the points made in the issue summary are correct. Which fix would you find useful here? So maybe we could proceed fixing this. (I also don't like the approaches from patches here)
- 🇮🇱Israel jsacksick
Yep, no problem around making the coupons field configurable...