Contrib.social

[meta] Fix update XML fixtures bad data

Open on Drupal.org →
Created on 4 February 2020, almost 5 years ago
Updated 17 April 2024, 8 months ago

Problem/Motivation

There are various problems with the update XML in core/modules/update/tests/fixtures/release-history

These problem don't make the test fail but should be fixed.

For example:

  1. aaa_update_test.8.x-1.2.xml should not have version_* tags
  2. Decide if all releases need core_compatibility
  3. core/modules/update/tests/modules/update_test/drupal.0.0.xml has <supported_branches>8.0.,8.1.</supported_branches> but no releases in the 8.1. branch while this is not "bad" data because this could happen it is not clear why this extra branch would be there and can be removed without affecting the tests.
  4. XML files that start with semver_test have the <tag> because they were added after #3113798: Remove unused (and generally wrong) markup from Update module test XML fixtures →

There are probably others.

The doc for this feed is https://www.drupal.org/drupalorg/docs/apis/update-status-xml →

Proposed resolution

Identify all problems and fix them.

Remaining tasks

  2. Decide if all releases need core_compatibility
  3. core/modules/update/tests/modules/update_test/drupal.0.0.xml has <supported_branches>8.0.,8.1. </supported_branches> but no releases in the 8.1. branch while this is not "bad" data because this could happen it is not clear why this extra branch would be there and can be removed without affecting the tests.
  4. 📌 Remove tag element from semver_test release history fixtures Active ; XML files that start with semver_test have the <tag> because they were added after #3113798: Remove unused (and generally wrong) markup from Update module test XML fixtures →

User interface changes

None

API changes

None

Data model changes

None

Release notes snippet

None

📌 Task
Status

Active

Version

11.0 🔥

Component
Update  →

Last updated 2 days ago

  • Maintained by
  • 🇺🇸United States @tedbow
  • 🇺🇸United States @dww
Created by

🇺🇸United States tedbow Ithaca, NY, USA

Live updates comments and jobs are added and updated live.
  • Novice

    It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.

  • Needs issue summary update

    Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment almost 2 years ago →
    needs-review-queue-bot

    The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

    Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

    Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

  • Status changed to Active 8 months ago
  • Comment 8 months ago →
    🇳🇿New Zealand quietone

    Moved #4 to a new issue, 📌 Remove tag element from semver_test release history fixtures Active

    I change the issue summary to be not open ended. A commit was stalled here in 2021 because of that. Let's fix the problems we know about and add new issues as more are found. Also, changing to a meta.

    That leaves 2 items to discuss and make child issue for, if needed.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024