- First commit to issue fork.
- Status changed to Needs review
4 months ago 2:26pm 3 September 2024 - 🇫🇷France prudloff Lille
I fixed it entirely in
EntityContentBase::updateEntity()but it might be cleaner to makeRow::$emptyDestinationPropertiesa nested array and move the splitting logic toRow::setEmptyDestinationProperty(). - 🇺🇸United States benjifisher Boston area
@prudloff:
You marked this issue as NR, but you marked MR 9400 as Draft. Please clarify the status.
I made a formatting suggestion on the MR, but I have not looked into the code yet.
- 🇺🇸United States benjifisher Boston area
There are some failing tests on the MR, but they do not seem related to this issue.
- 🇫🇷France prudloff Lille
I marked it as a draft because of this comment:
it might be cleaner to make Row::$emptyDestinationProperties a nested array and move the splitting logic to Row::setEmptyDestinationProperty()
The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.