- last update
6 months ago 795 pass - 🇮🇳India vinay.p
Hi,
I've implemented the fix in ProductVariationAttributesWidget. During an AJAX refresh, if the selected radio button from user input doesn't exist in the newly rebuilt #options, we just select the first radio button as fallback.
Please review and confirm. - Status changed to Postponed: needs info
4 months ago 3:00pm 20 August 2024 - 🇩🇪Germany Anybody Porta Westfalica
While the patch in #14 makes some sense to me, I read
Turns out that there was a second add to cart form on the same page (visually hidden) and this is causing the issue.
in #13 and there has been no other activity here since 2021. So I'm unsure if this issue still exists.
If someone runs into this, could you please update the issue summary with clear steps to reproduce and eventually provide some screenshots to better understand how this can be reproduced and what this is caused by?
- 🇺🇸United States morbus iff
@anybody: aye, this issue still existed for @vipin.j and I because we ran into it during our own QA of our platform.
- First commit to issue fork.
- Merge request !343Resolve #3107602 "Product attributes do not update visually when switching variations" → (Closed) created by ivnish
- Merge request !344Resolve #3107602 "Product attributes do not update visually when switching variations" → (Closed) created by ivnish
- Merge request !349Resolve #3107602 "Product attributes do not update visually when switching variations" → (Merged) created by ivnish
- Assigned to ivnish
- Status changed to Needs work
26 days ago 12:42pm 7 November 2024 - 🇮🇳India ankitv18
Left some comments on the MR ~~ leave this one in review state for further review
- 🇮🇱Israel jsacksick
Setting this as needs work... We already have tests coverage for attributes, and the tests are under the commerce_cart module. We don't need a new one under commerce_product.
Could you perhaps expand AddToCartMultiAttributeTest.php?
- ivnish Kazakhstan
Yes. I think I missed this test when looked for existing attributes test
-
jsacksick →
committed d27b834a on 3.0.x authored by
ivnish →
Resolve #3107602 "Product attributes do not update visually when...
-
jsacksick →
committed d27b834a on 3.0.x authored by
ivnish →