- π΅π±Poland Graber
Ok, thought about this a bit more after meeting with Maciek recently, the issue is about search_api only actually (maybe other view providers that don't include entities in result rows as well I'm not aware of as well). I'm willing to commit this but the admin config needs to be conditional. I think it'll be enough to check if
search_api
is in$this->view->getDependencies()
. If not we'll just set the config value to an empty string. Also, the last patch is incomplete.Still needs work but almost there if someone is willing to spend a bit more time on this.
- π§πͺBelgium rp7
Re-rolling patch against 4.2.x + an attempt to implement the proposal in #14.
- Status changed to Needs review
about 1 year ago 1:29pm 27 September 2023 - last update
about 1 year ago 9 pass, 4 fail The last submitted patch, 15: views_bulk_operations-checkbox_avoid_loading_entity-3106177-15.patch, failed testing. View results β
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- Status changed to Needs work
about 1 year ago 2:01pm 27 September 2023 - π΅π±Poland Graber
I'm glad this patch works for search_api views Raf but with it all core views with VBO are broken so it may be good only for sites that don't have any other type of views. I remember that's the case on your project but If you don't want to re-roll forever, please come up with a more universal approach.
- π΅π±Poland Graber
Let's also have a feature branch and a MR here if possible so it'll be easier to review and show places that cause errors.
- π΅π±Poland Graber
Sigh.. I think the only way to go here is to extend search_api and VBO API so instead of entity getter we have an entity info getter with 3 methods:
- get entity label,
- get bulk form key
- get entity properties from bulk form key
Wish I (or drunkenmonkey) thought about this earlier..
- π΅π±Poland Graber
I'll do the VBO work when I'll have time and deprecate the old entity getter method.. then we can start sorting out Search API side.
- π΅π±Poland Graber
Search API would have to know how to get the label so the proposed solution is also not good.
Let's just add a hook / dispatch an event so you can solve this in a custom module by providing that label and bulk form key. - Merge request !73Created additional API for view providers and custom implementations. β (Merged) created by Graber
- last update
about 1 year ago 15 pass - Status changed to Needs review
about 1 year ago 12:21pm 16 October 2023 - π΅π±Poland Graber
Ok, please test by creating an event subscriber that'll subscribe to
Drupal\views_bulk_operations\ViewEntityDataEvent::NAME
and provide those bulk form keys and entity labels withDrupal\views_bulk_operations\ViewEntityDataEvent::setViewEntityData()
.
In case of no activity for a month this'll be merged at some point and handled in a follow-up if needed. - last update
about 1 year ago 15 pass - last update
11 months ago 15 pass - last update
11 months ago 15 pass -
Graber β
committed 73d39a72 on 4.2.x
Issue #3106177 by rp7, gugalamaciek, falc0: Create API for view provider...
-
Graber β
committed 73d39a72 on 4.2.x
- Status changed to Fixed
11 months ago 11:13am 3 January 2024 Automatically closed - issue fixed for 2 weeks with no activity.
- πΊπΈUnited States andyg5000 North Carolina, USA
Filing a potential regression caused by this one, see π Missing checkboxes in 4.2.6 Active .
- π§πͺBelgium falc0
Hi Graber,
I was able to replace the code from the patch in #15 π Create API for view provider modules to provide entity labels and bulk form keys Fixed with custom code but I would still add this to your codebase if possible.